Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 21 May 2021 19:26:02 +0100
From:   Cristian Marussi <cristian.marussi@arm.com>
To:     Axel Lin <axel.lin@ingics.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: scmi: Fix off-by-one for linear regulators
 .n_voltages setting
Message-ID: <20210521182602.GM28060@e120937-lin>
References: <20210521073020.1944981-1-axel.lin@ingics.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210521073020.1944981-1-axel.lin@ingics.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

Hi,

On Fri, May 21, 2021 at 03:30:20PM +0800, Axel Lin wrote:
> For linear regulators, the .n_voltages is (max_uv - min_uv) / uv_step + 1.
> 
> Fixes: 0fbeae70ee7c ("regulator: add SCMI driver")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---

Right. Good catch.

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks,
Cristian

>  drivers/regulator/scmi-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/scmi-regulator.c b/drivers/regulator/scmi-regulator.c
> index bbadf72b94e8..1f02f60ad136 100644
> --- a/drivers/regulator/scmi-regulator.c
> +++ b/drivers/regulator/scmi-regulator.c
> @@ -173,7 +173,7 @@ scmi_config_linear_regulator_mappings(struct scmi_regulator *sreg,
>  		sreg->desc.uV_step =
>  			vinfo->levels_uv[SCMI_VOLTAGE_SEGMENT_STEP];
>  		sreg->desc.linear_min_sel = 0;
> -		sreg->desc.n_voltages = delta_uV / sreg->desc.uV_step;
> +		sreg->desc.n_voltages = (delta_uV / sreg->desc.uV_step) + 1;
>  		sreg->desc.ops = &scmi_reg_linear_ops;
>  	}
>  
> -- 
> 2.25.1
>