Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1405610pxj; Fri, 21 May 2021 13:28:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtHvegWndu1iK9iLObFL55wP7lLkyPedE/pcvzaUmvHAjp77oy3hJX8AyCtsSqkFY984I2 X-Received: by 2002:aa7:cb84:: with SMTP id r4mr12981233edt.187.1621628901059; Fri, 21 May 2021 13:28:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621628901; cv=none; d=google.com; s=arc-20160816; b=hbHT78txAFBrjrq2i9t+ToBlCRR0dhBhFCGabV+G7L0pmqLP/oWczJn8nIod8a4/78 N+qs45YgbLLc6g9SZnLwsvqNsW8XGQrrwbWwFYIUY7qq8oOOXORJzLUOzXSFNmh50l57 5lYmxueLBXZW+M5bevYe1mWW9YfmmC+4LZaVxb4aicefMn4oNJobQ0rLsn4ga1Vjr5Ls MVCS/ALX52NJKz4hIEIGXgRw0mmkiyHnx4idvlaWM+26hpitUJh/hClK+YFvLi5G5VbD NnS1bxf42l0q/gPJMni922vL5IaZIgFwD+AE6FHx8Oby4JgVtRpvc/6Xu/6rzulyQvdA G/6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=bGRajSv+AD1mZQAVLyG2kZ2Kr4IYsKoeQJXTk9dYEgI=; b=u/Likq0W1KzQoSd/D2OkjNPqyoJH4QxUUpLcqPC6j+jN/axw6QxIquYoFENEe8B4Hu LMtuERVNaOnmhS25HyrRnOuP1FvdxJInWGzEvpPqGMkaKUwbvzCGQC4vSz6HtSz0I796 BTLMc0eCRFzu/NLTAQ3emSTY0QDUSrnkY/Kb8oWEDQI7JL0XKorq1o+7wm6bqJEyZ1kk 7rGGKo4zWm+xTBn/ecpd60ZAH7703cokCwZayJXtbuy05ikDPrRhWqcHpbQtFzZHMUA0 BaWFVUg/9XDQXeq2ixXo2ZwETVx/63phtLSdsEH6enA7oFXkJD8nrWlj8jtqjqwjZWCk cIlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lu22si6209907ejb.51.2021.05.21.13.27.57; Fri, 21 May 2021 13:28:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235287AbhEUTQh (ORCPT + 99 others); Fri, 21 May 2021 15:16:37 -0400 Received: from mga05.intel.com ([192.55.52.43]:42606 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232629AbhEUTQg (ORCPT ); Fri, 21 May 2021 15:16:36 -0400 IronPort-SDR: YLRG6XohHxHQ47CaBH0cELbqOf/QmvQ/9ap2LwGdncNXXerSCC1puJKvKPrNhe7HXrdoNQpVnP dx8NUVCsz7pg== X-IronPort-AV: E=McAfee;i="6200,9189,9991"; a="287096507" X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="287096507" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2021 12:15:12 -0700 IronPort-SDR: OAj3Ix/FMDi7MxYA5hHUy1iTg61GxXHwCh08gNk5T59MUCYpWAgoDmCUo+jY21N1kDZJrmwel4 hkoX7/XD0s5g== X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="613353393" Received: from pburton-mobl.amr.corp.intel.com (HELO [10.209.36.169]) ([10.209.36.169]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2021 12:15:12 -0700 Subject: Re: [RFC v2-fix 1/1] x86/traps: Add #VE support for TDX guest To: "Kuppuswamy, Sathyanarayanan" , Peter Zijlstra , Andy Lutomirski Cc: Tony Luck , Andi Kleen , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Dan Williams , Raj Ashok , Sean Christopherson , linux-kernel@vger.kernel.org, Sean Christopherson References: <20210518000957.257869-1-sathyanarayanan.kuppuswamy@linux.intel.com> <3573599f-56bc-f21e-7a7e-0d441ab9d68e@linux.intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <867d1271-ff97-40b0-16a5-ccf875c0ad7b@intel.com> Date: Fri, 21 May 2021 12:15:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <3573599f-56bc-f21e-7a7e-0d441ab9d68e@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/21/21 11:45 AM, Kuppuswamy, Sathyanarayanan wrote: > You have any other comments on this patch? If not, can you reply with your > Reviewed-by tag? Sathya, I've been rather busy with your own patches and your colleagues TDX patches. I've clearly communicated to you which patches I plan to provide a review for. I'll get to them, although not quite at the speed you would like. If you would like to get a quicker review, I'd highly suggest you go find some of your TDX colleagues' code that needs its quality improved and help by providing them reviews. Reviews are a two-way street, not just a service provided by maintainers to contributors. You could also make good use of your time by going back over all of the review comments I've made up to this point and doing a pass over your work to ensure that I don't have to continue to repeat myself and waste review efforts. You could add a spell checker to your workflow, or scripting to check for language conventions like avoiding "us" and "we". You could also seek out help to raise the quality of your communications. It isn't just reviewers that can help raise the quality of your contributions.