Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Daniel Wagner <dwagner@suse.de>
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH] scsi: scsi_transport_fc: Remove double FC_FPORT_DELETED
 in mask creation
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1sg2f3iub.fsf@ca-mkp.ca.oracle.com>
References: <20210520073127.132456-1-dwagner@suse.de>
Date:   Fri, 21 May 2021 16:58:10 -0400
In-Reply-To: <20210520073127.132456-1-dwagner@suse.de> (Daniel Wagner's
        message of "Thu, 20 May 2021 09:31:27 +0200")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.ca.oracle.com (138.3.200.58) by SN4PR0501CA0131.namprd05.prod.outlook.com (2603:10b6:803:42::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.11 via Frontend Transport; Fri, 21 May 2021 20:58:13 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 85adfb85-1b15-4bc7-5131-08d91c9b2682
X-MS-TrafficTypeDiagnostic: PH0PR10MB4709:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB47096B80E4912FB2C95605D78E299@PH0PR10MB4709.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: VXBPDQg/gyRu2Huc2r6LhDmHgj3jvLXKupdmOsZ6PdhFv0Sq2YQb8HiQeWnGW8MnhptQv1gmRKohjN7WTjXjlTmGLWC5nkJG+JA01s5RmTZlucBjGIPmOGQ5N66rWZHJuzBaEZPz41WiC5SBcQR7uPsRpGTu6IVpxaWDcj/ri77p63udfTOCvZecEgB1A74tye62fqLHlKs4D1UmisqZE140PxowtCI71WtrHbJVVNw7Q3TlsjSGF4qBZz+ms8/ttZLUpqfq3OTK967NZ5nTeuENsy71OgdYppPn7hD8Fpd3ZngazfSJtsK8GiBMhGYz7w20P9mPVE6iVgwh+BfwpaTXGGmsQyAuzrQDIC/mIGOPRleZR3/XCrVZdvIeliesWpfFBusTiWszntARM85Pmt9bISluVuHbdLPKbcYPKjuOaPF7x2bpjjf/YutmST204XyZxR4GIZO7qLStQYrI/0SfQI3Iw5kfWIe6IRTup+wQuGSAvllHigQ7NR639GfCFwSa66/AruWsLqpDepWPnbdFjRyQSOwK2gUrdb+XjHLpQo7RahaHvtue3u6PXmfBy18ktM7CBNwxykgtZygWFSK7PCjDBPebbscVwpobo5ETB5ZdEGsA5yYnROlWhnwCUl8y6uGKpydbFVucnZIDJvDoWrPKJwQzupBetDg6mm4=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(396003)(136003)(39860400002)(366004)(316002)(66476007)(36916002)(54906003)(7696005)(52116002)(16526019)(8936002)(956004)(186003)(8676002)(4744005)(66556008)(66946007)(86362001)(5660300002)(83380400001)(6916009)(2906002)(478600001)(38100700002)(38350700002)(55016002)(4326008)(26005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?TlZe3S+YC1Th/1cLcx2KqMTqN/3JkD8+AbnPGZBI/JI6ogsAa4ufEtjZs2wC?=
 =?us-ascii?Q?qNOTE1F1VFw5Ls3UZq/ZZD4060r+3zSJBSY3xrG0e03FXHscfjj1XjbO4Fy9?=
 =?us-ascii?Q?vwNcwgQIZAwXCWW9wiH+4fr35zDz7yqgmLWvHz2fOVuMbcFHAflsP8OyBaKm?=
 =?us-ascii?Q?L6xjC5YJRAe/tX4Mc4//kpWfnjU1H2DlWzizTeudKkBObRgAcS0K1BAbY/nY?=
 =?us-ascii?Q?jHRxFfNBgZnUjm20KbskSTju0mGNV5L8IMpn7w0hTw/aUubWxC7piITkXM4S?=
 =?us-ascii?Q?OghDZ/5ebAN4h75QsPqMHGrctHHUopPGoSHNnNpJXVMujBaAQLa7D7OB4WFk?=
 =?us-ascii?Q?thul316iGpUaC9NxDy8k6eaa+16m7lv99gBbSYC779oC6gmfWu63tBdr43gu?=
 =?us-ascii?Q?14m43Pj+698Dr3deuRuGMJJohilsJZmq9hu0+ayzRnw4Y4ssAGZ8OXDER4zx?=
 =?us-ascii?Q?UqKBHKsm8p+URcPOb0lkEbQjv0lZZUW2a10TW5KeHEWj/RNf3QaCTt4lNhDe?=
 =?us-ascii?Q?vu3ixHScNidyVrqrAV7SM9cGWize5I5E2Xu0dmQjeSJ5hW3B04YLIDATrpNy?=
 =?us-ascii?Q?7VLJjpaSDaSDMpE0doVeA1uD3g6PHAva+EmPsoZBTg5p9OXt+uTDkUf12dIx?=
 =?us-ascii?Q?mBjckyZPefsf+JGCXFu/68nkRpLi9LQm4cD3L4X6nuB80iU9InxXT11b24uz?=
 =?us-ascii?Q?W85vEKGaAoRyh4EfR36hHNQ7p0pwJ5kCshWMqH79Fs+6Rtfd7GBQOK554VnK?=
 =?us-ascii?Q?n5mpW5Kn5Ib0ZJ3r27ARGfe24CnHmP9/II3eYsDeCXkzT1YS0CiPOHrwoURR?=
 =?us-ascii?Q?xDZ95cymT1DRb82DWKqfi+nRAOh3NIWnFPHTyBY7uUhte/j813MozpHdzKq7?=
 =?us-ascii?Q?EpQMcqz9xR+ziLoKUx9hLr+UIzNlq2lc8J+hc1fBnSwIjpl4w/WX7ZwxBmGz?=
 =?us-ascii?Q?zNZI1AN1g+vk0ZwtKND3SUpMuqrQzGR0llIWuVBmBjHKdrUW9ArxtvzXKv06?=
 =?us-ascii?Q?m5j/UeJvNMp+Q308kGwHvldnjfEiQjRO+qd9CgX26fG/RWbOcytcVUFB2OIl?=
 =?us-ascii?Q?79rK+7eNrNBYiBcJcywcBFdbqcWGpmUJEuFrsTtEBSCXoepZ1/qz5O0Z5HZs?=
 =?us-ascii?Q?hS4ELZNo9C+FY7oK+qJGusDLLuu9tHULvr01S4GutBtnJGXWYg54jtgQ9R/y?=
 =?us-ascii?Q?q27HbBzpzoDOmiy8AlaVcc9Ky/NsDPFMZZeHIlOsH29NcHnrubi4q9PLiXOY?=
 =?us-ascii?Q?/i7iro9qTKg524hvauDHKJxkXFMDvk9F3HBcojroNKc3jYLrl9G82xjg1t9B?=
 =?us-ascii?Q?6rWYAIBOxwiXaw2iHl+TaaVf?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85adfb85-1b15-4bc7-5131-08d91c9b2682
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2021 20:58:14.2423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n7SnoIJ9kKWANtm+h4Un39oc+Go7R3Q7yLJLq+m2zZXG4MktI8QJF0l4HjhGFV9Q2cU79c6bbixwqRDA8bqTEG4xNBkIBKFg54lLNZ5C7L8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4709
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9991 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 adultscore=0
 phishscore=0 malwarescore=0 bulkscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2105210113
X-Proofpoint-ORIG-GUID: AA4TySuT5X-f1L7jcIdjsFMRDOJhV2Vn
X-Proofpoint-GUID: AA4TySuT5X-f1L7jcIdjsFMRDOJhV2Vn
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9991 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 malwarescore=0
 spamscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=999 mlxscore=0
 impostorscore=0 adultscore=0 clxscore=1015 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2105210113
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Daniel,

> Remove the double listed FC_FPORT_DELETING from the mask creation.
>
> Commit 260f4aeddb48 ("scsi: scsi_transport_fc: return -EBUSY for
> deleted vport") added VC_VPORT_DELETING to the flag masks. This is not
> necessary as FC_FPORT_DEL is defined as VC_FPORT_DELETED |
> FC_FPORT_DELETING.

Applied to 5.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering