Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210521150212.2076151-1-linux@roeck-us.net>
In-Reply-To: <20210521150212.2076151-1-linux@roeck-us.net>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 21 May 2021 17:00:24 -0400
Message-ID: <CADnq5_P9C71cc0Ua7cSYwkTPgY_YDXBOw-==XtXQCH+rxgW9Fw@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/amdkfd: Drop unnecessary NULL check after container_of
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Felix Kuehling <Felix.Kuehling@amd.com>,
        David Airlie <airlied@linux.ie>,
        LKML <linux-kernel@vger.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Fri, May 21, 2021 at 11:02 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> The first parameter passed to container_of() is the pointer to the work
> structure passed to the worker and never NULL. The NULL check on the
> result of container_of() is therefore unnecessary and misleading.
> Remove it.
>
> This change was made automatically with the following Coccinelle script.
>
> @@
> type t;
> identifier v;
> statement s;
> @@
>
> <+...
> (
>   t v = container_of(...);
> |
>   v = container_of(...);
> )
>   ...
>   when != v
> - if (\( !v \| v == NULL \) ) s
> ...+>
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index 5b6c5669c03d..2f8d352e0069 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -110,8 +110,6 @@ static void kfd_sdma_activity_worker(struct work_struct *work)
>
>         workarea = container_of(work, struct kfd_sdma_activity_handler_workarea,
>                                 sdma_activity_work);
> -       if (!workarea)
> -               return;
>
>         pdd = workarea->pdd;
>         if (!pdd)
> --
> 2.25.1
>