Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <2977129b-c568-8ce5-9a85-31473096719f@linux.intel.com> <20210521143941.2528475-1-sathyanarayanan.kuppuswamy@linux.intel.com>
In-Reply-To: <20210521143941.2528475-1-sathyanarayanan.kuppuswamy@linux.intel.com>
From:   Dan Williams <dan.j.williams@intel.com>
Date:   Fri, 21 May 2021 11:29:42 -0700
Message-ID: <CAPcyv4gYjkL6kO0ZY+a_ehMz__yyr_VgMwfZOkQranqfuA4n7Q@mail.gmail.com>
Subject: Re: [RFC v2-fix-v2 1/1] x86/boot: Add a trampoline for APs booting in
 64-bit mode
To:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kirill Shutemov <kirill.shutemov@linux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
        Raj Ashok <ashok.raj@intel.com>,
        Sean Christopherson <seanjc@google.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, May 21, 2021 at 7:40 AM Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com> wrote:
>
> From: Sean Christopherson <sean.j.christopherson@intel.com>
>
> Add a trampoline for booting APs in 64-bit mode via a software handoff
> with BIOS, and use the new trampoline for the ACPI MP wake protocol used
> by TDX. You can find MADT MP wake protocol details in ACPI specification
> r6.4, sec 5.2.12.19.
>
> Extend the real mode IDT pointer by four bytes to support LIDT in 64-bit
> mode.  For the GDT pointer, create a new entry as the existing storage
> for the pointer occupies the zero entry in the GDT itself.
>
> Reported-by: Kai Huang <kai.huang@intel.com>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> ---
>
> Changes since RFC v2-fix:
>  * Passed rmh as argument to get_trampoline_start_ip().
>  * Added a comment line for get_trampoline_start_ip().
>  * Moved X86_CR0_NE change from pa_trampoline_compat() to patch
>    "x86/boot: Avoid #VE during boot for TDX platforms".
>  * Fixed comments for tr_idt as per Dan's comments.
>  * Moved TRAMPOLINE_32BIT_CODE_SIZE change to "x86/boot: Avoid #VE
>    during boot for TDX platforms" patch.

Thanks, looks good, no more comments from me:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>