Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1455672pxj; Fri, 21 May 2021 15:00:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxI7vVJ4XECzQJSrgCmhmPmial/dFkAZBr9Vnb4Zr+YWvjAO7MJxY/fq8NsoxS4H4a0zZ6 X-Received: by 2002:a05:6402:21dd:: with SMTP id bi29mr13083285edb.29.1621634440059; Fri, 21 May 2021 15:00:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621634440; cv=none; d=google.com; s=arc-20160816; b=Nw1lTmapVyMIOWoNtwK7NgWOGHBn675Wwt+XzsKHv+GaZeQ0NWKYV0hQq5etctfOIp YHyaEUqbvWHHRGqYrvzE8D5rJZOyckCuqcPkjAgKyteGHrV+iWDxLTELeoB0oykV6xc9 EdiTtxNb4IWXKZ8IpG2fy5zk/INIjbuicauHUl88FnUYLGAujZ04LN/0zstN5fM2fr7Q Gga0PUav7lLnWWokyOe3QLfSkJ7mZT4YMRAYbE3yoAz0NqLJTzdGhbnSk1YWE0GZztW5 SCI5mb8GckFZ1n/+GpCWtg7MFmbVtTHSpjy+Ri3kl9t4WAp4cjW4uilDx4uAEZZqsWnk 5Lhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=Pd7ky5cxDb+qxzJPiCzfS73ME9CuHoqRQM37v+k83B4=; b=iTvLrv9BsZuFoQPvQsYEO8lz4DLZeeh7YCOsOcBKJsTOwBNVaqy0zppfoRmHajypYE symPiheTabAyP3R8YjSIQ8cIo1C4rch5zceHBX+5EWvKrjh4DAW768A1isE7COAULyo8 oaqhT7UtMtoA+yHNYdPzhetP7JB0aii6xGI0r6xr9Eqya0j6ocyB4jH1rUe8ZnMYyuQh qmtQBBVI32gN4U1kgyN1PYHmFSn8F1/08Zy7A0OblDicA3fyvfT8evlW3QSLd7kH5lOG +gDV1oiOAJ6jwj06AM4tFs573G2zxglz9sPf3H4wEE5wGFVg113VDZOY6xqAgsWzMw11 qiCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="hEWVM/nv"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y16si6504437edc.193.2021.05.21.15.00.16; Fri, 21 May 2021 15:00:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="hEWVM/nv"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229519AbhEUV6g (ORCPT + 99 others); Fri, 21 May 2021 17:58:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbhEUV6f (ORCPT ); Fri, 21 May 2021 17:58:35 -0400 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63823C0613CE for ; Fri, 21 May 2021 14:57:12 -0700 (PDT) Received: by mail-ot1-x32d.google.com with SMTP id 80-20020a9d08560000b0290333e9d2b247so8807428oty.7 for ; Fri, 21 May 2021 14:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=Pd7ky5cxDb+qxzJPiCzfS73ME9CuHoqRQM37v+k83B4=; b=hEWVM/nvf00TFCvYEtUvgRbGojwxiR3Xlb4OIR6nUJv/kcZu76ZTGZ7ogyUEeilbIC tZYDOwLEzD9l2dpBfqePGUkwUp2OYTw16Kip9gbdyR0H1OKM42auzXMCFM+47ulZUuph 6Lym33huSHkbIkeNSWu3+jZgbAA1er/HDgAug= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=Pd7ky5cxDb+qxzJPiCzfS73ME9CuHoqRQM37v+k83B4=; b=Vbz2QtP5b1NOiR2HoVComR5wlcLIGbLfAToXY9Gd0K+IvT+ZlQC12IW5hgMqUTZlNm 6GblSkY8ujv7lxKanR+bKFxMTRvD1dqT0hpP9J67ukEC1KFpOzeB4ZFHAlIBIntKITnn uUieIBmLiZNgVipFVlMKIrSL21/inHqUPGgiSIIAE935ofw5wxRO6+1cKudJ33lwRTIC XARj5LVItWXk7OK70469VpAsPhSEy1DKAT6rw2f8mYMNeWkj8oCa42h2NyNjsDYePDbH EXogCdjM3n+34pXHHfYDwxkWfDKHEAyddLQ9a5VXfkh5hkNW7wVebHK4mtbUGWkgGJoY wreA== X-Gm-Message-State: AOAM5309dMQA2Ww5DWLraMyDaUwZe35T6OEqt9v5bm2q47rBEmqU8hvh Wg2KIIk9waIYtwtu5z9HAN76UE0ZLhDKCYTU/2YuoA== X-Received: by 2002:a05:6830:4a1:: with SMTP id l1mr10235034otd.25.1621634231832; Fri, 21 May 2021 14:57:11 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 21 May 2021 14:57:11 -0700 MIME-Version: 1.0 In-Reply-To: <20210507212505.1224111-1-swboyd@chromium.org> References: <20210507212505.1224111-1-swboyd@chromium.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Fri, 21 May 2021 14:57:11 -0700 Message-ID: Subject: Re: [PATCH 0/3] drm/msm/dp: Simplify aux code To: Rob Clark Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Dmitry Baryshkov , Abhinav Kumar , Kuogee Hsieh , aravindh@codeaurora.org, Sean Paul Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Stephen Boyd (2021-05-07 14:25:02) > Here's a few patches that simplify the aux handling code and bubble up > timeouts and nacks to the upper DRM layers. The goal is to get DRM to > know that the other side isn't there or that there's been a timeout, > instead of saying that everything is fine and putting some error message > into the logs. > > Cc: Dmitry Baryshkov > Cc: Abhinav Kumar > Cc: Kuogee Hsieh > Cc: aravindh@codeaurora.org > Cc: Sean Paul > Kuogee, have you had a change to review this series? > Stephen Boyd (3): > drm/msm/dp: Simplify aux irq handling code > drm/msm/dp: Shrink locking area of dp_aux_transfer() > drm/msm/dp: Handle aux timeouts, nacks, defers > > drivers/gpu/drm/msm/dp/dp_aux.c | 181 ++++++++++++---------------- > drivers/gpu/drm/msm/dp/dp_aux.h | 8 -- > drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +- > drivers/gpu/drm/msm/dp/dp_catalog.h | 2 +- > 4 files changed, 80 insertions(+), 113 deletions(-) > > > base-commit: 51595e3b4943b0079638b2657f603cf5c8ea3a66 > -- > https://chromeos.dev >