Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1486256pxj; Fri, 21 May 2021 15:58:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfgNDe2u94I4TURmQRnaL06o8xIihj5knS0qtiWIzgm3nbI2eq5REnjV2etG+mECQ167H5 X-Received: by 2002:a05:6e02:68c:: with SMTP id o12mr1306685ils.92.1621637928817; Fri, 21 May 2021 15:58:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621637928; cv=none; d=google.com; s=arc-20160816; b=MExv+kJYu0WrMe6lTglxI27LhD8Zi1TOidF07RNxWcbtzaMzDW4bspx8OyqZ7Uy3CH 0YlbywpoaUkmDjBHQR2UoX0qzu/B2mMYHXpZM6h8n/XxYde+JKOMk4WSEcapzw79IhMa twz/+ROeNGAr+AXb7gdOQ+SFlKqOq6U8zJTUTZ5anQZN5J5QZOY5vtJnbBbMsuWciZJ5 GOr5IKZLVoBhpZeoEEeKj2S5WEjFt0yElx45za2ESiZABQR3iJaQd9W45GfJEHiouHa4 KpG0P8GEBpK/XsvWoNWWLg8jWRcyc8loPRa8j65+OKjoEAO8jprTQEYRYPQ1Lp8gTJ+h ooCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=qIBQFw/KgW2TaVUNNSn81/M3Aq2F72pWWTPJdN8jFE8=; b=ldNYTIZHBS98PMhuI/vSsEwhRHlRvUNeiCCY3VisRKx316qxW8E0eB4CMxx6y+1yeR O0mM+D2Wulur+zJBLRnQN819Bd7bJfj7lWMdeS2hVvgaPQorboTtg7Cy5ovr8yv9YIYt g+6MhWNi3HRFG1+WUan/Nyf7oxOKQcyYljrtsbPSFhP0izwkkQIxYVkPEohZVIFBwIP0 4HeAFTRhEWLiVBWhqAGq+zQKG4AktlkakOXP17kOn7qI1M7kuCWeJOj/qQThFDJJh3y7 MxgLME76aU7LDmNbqROyBsz6EcofoxcyVq4MvVvrzhYzTeobIApEjz7zxSxAjjDmxIXE M/kQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s18si7027605ilh.102.2021.05.21.15.58.35; Fri, 21 May 2021 15:58:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229940AbhEUW6v (ORCPT + 99 others); Fri, 21 May 2021 18:58:51 -0400 Received: from mga06.intel.com ([134.134.136.31]:62985 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229655AbhEUW6r (ORCPT ); Fri, 21 May 2021 18:58:47 -0400 IronPort-SDR: csUo8XrueBcM4iNAJ3ow1NNqW+phmr9SL1KLEfmuDD0Pe+h9qa1eu1VGAHxRZa+vjx/4//QLH9 0uTQxtgPgRvw== X-IronPort-AV: E=McAfee;i="6200,9189,9991"; a="262807288" X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="262807288" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2021 15:57:23 -0700 IronPort-SDR: xbpNSsUlAxTX/kbcdusQpqrnNZKQyJLWPlwqOf3U9AOiSy9mCymfZi6p5/rDxtZLfUdOL15TLe CDY1crP72yLA== X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="441130087" Received: from djayapra-mobl2.amr.corp.intel.com (HELO [10.212.209.34]) ([10.212.209.34]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2021 15:57:23 -0700 Subject: Re: [PATCH 6/6] mm/page_alloc: Introduce vm.percpu_pagelist_high_fraction To: Mel Gorman , Linux-MM Cc: Dave Hansen , Matthew Wilcox , Vlastimil Babka , Michal Hocko , Nicholas Piggin , LKML References: <20210521102826.28552-1-mgorman@techsingularity.net> <20210521102826.28552-7-mgorman@techsingularity.net> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Fri, 21 May 2021 15:57:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210521102826.28552-7-mgorman@techsingularity.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/21/21 3:28 AM, Mel Gorman wrote: > This introduces a new sysctl vm.percpu_pagelist_high_fraction. It is > similar to the old vm.percpu_pagelist_fraction except it only adjusts > pcp->high to potentially reduce zone->lock contention while preserving > allocation latency when PCP lists have to be refilled. Look at me... Five patches later and I already forgot what the old one did and why it stinks. I wonder if you might do a wee bit of compare and contrast. Something like: The old vm.percpu_pagelist_fraction increased both the batch and high limits for the per-cpu page allocator. Its worst feature was that it led to absurdly large batch sizes that incurred nasty worst-case allocation latency. This new sysctl in comparison... Anyway, the approach looks sound to me. The batch size isn't important now, especially given the auto-scaling in patch 4. Acked-by: Dave Hansen