Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210521162041.GH8544@kitsune.suse.cz>
In-Reply-To: <20210521162041.GH8544@kitsune.suse.cz>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Fri, 21 May 2021 17:46:27 -0700
Message-ID: <CAEf4BzbgJPgVmdS32nnzd8mBj3L=mib7D8JyP09Gq4bGdYpTyg@mail.gmail.com>
Subject: Re: BTF: build failure on 32bit on linux-next
To:     =?UTF-8?Q?Michal_Such=C3=A1nek?= <msuchanek@suse.de>
Cc:     Networking <netdev@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        open list <linux-kernel@vger.kernel.org>,
        bpf <bpf@vger.kernel.org>,
        clang-built-linux <clang-built-linux@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, May 21, 2021 at 9:20 AM Michal Such=C3=A1nek <msuchanek@suse.de> wr=
ote:
>
> Hello,
>
> looks like the TODO prints added in 67234743736a6 are not 32bit clean.
>
> Do you plan to implement this functionality or should they be fixed?

They should be fixed regardless. Can you please re-submit as a proper
patch to bpf@vger.kernel.org with [PATCH bpf-next] subj prefix?

>
> Thanks
>
> Michal
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 69cd1a835ebd..70a26af8d01f 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -4565,7 +4565,7 @@ static int init_map_slots(struct bpf_object *obj, s=
truct bpf_map *map)
>                 targ_map =3D map->init_slots[i];
>                 fd =3D bpf_map__fd(targ_map);
>                 if (obj->gen_loader) {
> -                       pr_warn("// TODO map_update_elem: idx %ld key %d =
value=3D=3Dmap_idx %ld\n",
> +                       pr_warn("// TODO map_update_elem: idx %td key %d =
value=3D=3Dmap_idx %td\n",
>                                 map - obj->maps, i, targ_map - obj->maps)=
;
>                         return -ENOTSUP;
>                 } else {
> @@ -6189,7 +6189,7 @@ static int bpf_core_apply_relo(struct bpf_program *=
prog,
>                 return -EINVAL;
>
>         if (prog->obj->gen_loader) {
> -               pr_warn("// TODO core_relo: prog %ld insn[%d] %s %s kind =
%d\n",
> +               pr_warn("// TODO core_relo: prog %td insn[%d] %s %s kind =
%d\n",
>                         prog - prog->obj->programs, relo->insn_off / 8,
>                         local_name, spec_str, relo->kind);
>                 return -ENOTSUP;