Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 22 May 2021 08:46:10 +0200
Message-ID: <s5hh7ivfeq5.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     trix@redhat.com
Cc:     perex@perex.cz, tiwai@suse.com, gustavoars@kernel.org,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: initialize the cur variable
In-Reply-To: <20210521194603.2077623-1-trix@redhat.com>
References: <20210521194603.2077623-1-trix@redhat.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 21 May 2021 21:46:03 +0200,
trix@redhat.com wrote:
> 
> From: Tom Rix <trix@redhat.com>
> 
> Static analysis reports this problem
> clock.c:338:10: warning: The right operand of '=='
>   is a garbage value
>     if (i == cur)
>           ^  ~~~
> 
> In __uac_clock_find_source() the goto find_others skips over
> setting of the 'cur' variable.  Since the pin loop variable
> starts with 1, it is safe to initialize cur to 0.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Thanks for the patch, but this has been already fixed in for-next
branch.


Takashi