Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1806342pxj; Sat, 22 May 2021 02:27:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkAsE/qtPR+Clpk4fi8DkYvWNGtBjEU6mAdiugdyqiNS1ESJsW0q7QQzMAe0JFblNeTcUC X-Received: by 2002:a5d:804f:: with SMTP id b15mr3873780ior.187.1621675676045; Sat, 22 May 2021 02:27:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621675676; cv=none; d=google.com; s=arc-20160816; b=jplQSBlyagtDNXx/IlQRXruG0VYv+5z3giSCDz6dTPmgvlB2vz3c1X5vWtTaaglOkm olUrOQk4c2fiO2wFBBF7M9XXDAyra6bNoLwBRNbdav9YKaLtw3/GHZJRHDegmRTnQvXj Bwt5kQr4TTKPJbx3AUg5t2ejmtHPM2rlTfEIPIBb8G8x1NUYO39C0fM2r5wNznFjZoCE 2w1eOQFgHcGAY8x7T8jQ1we4DPKN0qp3FBDvSa2o9IA3fe1jGQxOoxgU/7Yyg9c0NVSZ /rGWCyfi78Daq8qTpPC6QAurFanFko4bJC7XrVoELnR3nz+wluuTW9tVff/lEUkFIQMc jpCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=QUXpezeHpkd1ZMtyRPMLMLtYac8KD3Ma0fV4u/DgXsY=; b=MQ7RkoaK7oLWbyUdkOyUbCgPpOE0eJjiBTLfn+4Sx2grT/2SZon2HgChphXZscqWxd gMLs+t2LvMdOxi9weWN76S38tz234uGEQBQC6DvpCQAaP/LqtAeSa8AT0B3ByYKzHDCA VamqwePWrGdEj3JmCoPyX5aM7BGFMhOtSNesXpj1zgs771CXtXFwgJ64HlkA2wdfGSlo HtWQh+cBYkMCMRcMIUXdAPrmQ/ENO9pGfQFjRj8LYQ5Y3GpqQC6IeT1ovhA83qQAKwkR 7RjTNiYbyridDHU2lu+VIgrGPU7JjTB8V4+cVc1S97g1GORolgIDSBSRKHauDSoe82h+ t69g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=K7GbLNOR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q13si10074689ilg.125.2021.05.22.02.27.42; Sat, 22 May 2021 02:27:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=K7GbLNOR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230168AbhEVJ2T (ORCPT + 99 others); Sat, 22 May 2021 05:28:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:48356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230137AbhEVJ2R (ORCPT ); Sat, 22 May 2021 05:28:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 81EE561090; Sat, 22 May 2021 09:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621675613; bh=aQAR0Z09kZdoFhigfeEe2x7py2pznctlRs5s0ni7rNc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K7GbLNORGpuqK4qWlDz6laompMVTHbiTjvCAe385F5iPeytRPS/trYpp6Qz2UYd8s sqlYRZNXg400R+flvyLeii6CcvdUDTf1faRvrAWZzG1Va+o7Qn2hCen7k+uJ0UevP3 K9XUrtA/fiTAecXLpTDlmWTwLw9NO1qvq2ynUGCU= Date: Sat, 22 May 2021 11:26:50 +0200 From: Greg KH To: Shreyansh Chouhan Cc: fabioaiuto83@gmail.com, ross.schm.dev@gmail.com, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [Resend] [PATCH 1/2] [RFC] staging: rtl8723bs: refactor to reduce indents Message-ID: References: <20210522092024.65018-1-chouhan.shreyansh630@gmail.com> <20210522092024.65018-2-chouhan.shreyansh630@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210522092024.65018-2-chouhan.shreyansh630@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 22, 2021 at 02:50:23PM +0530, Shreyansh Chouhan wrote: > Reduce the number of indents in rtw_wlan_util.c file by refactoring the > code. > > Moved the part of code that rearranged ac paramaters in the function > WMMOnAssocResp to a separate function named sort_wmm_ac_params. It takes > both the array of ac params and their indexes as arguments and sorts them. > Has return type void. > > Moved the part of code that checked for the realtek vendor in the > function check_assoc_AP to a separate function named > get_realtek_assoc_AP_vender. It takes a pointer to struct > ndis_80211_var_ie as an argument and returns a u32 realtek vendor. > > Signed-off-by: Shreyansh Chouhan > --- > .../staging/rtl8723bs/core/rtw_wlan_util.c | 108 +++++++++--------- > 1 file changed, 56 insertions(+), 52 deletions(-) Why is [RFC] in the subject line? Do you not want these merged? confused, greg k-h