Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210515081404.6334-1-pmenzel@molgen.mpg.de>
In-Reply-To: <20210515081404.6334-1-pmenzel@molgen.mpg.de>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Sat, 22 May 2021 14:09:29 +0200
Message-ID: <CAMj1kXGCGysZCk59yMjsKWX5PcENvJnyv0nV12kGYObtjE3x3w@mail.gmail.com>
Subject: Re: [PATCH] x86/efi: Log 32/64-bit mismatch with kernel as an error
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     Darren Hart <dvhart@infradead.org>,
        Andy Shevchenko <andy@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        linux-efi <linux-efi@vger.kernel.org>,
        platform-driver-x86@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, 15 May 2021 at 10:14, Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Log the message
>
>     No EFI runtime due to 32/64-bit mismatch with kernel
>
> as an error condition, as several things like efivarfs won=E2=80=99t work
> without the EFI runtime.
>
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
>  arch/x86/platform/efi/efi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
> index 8a26e705cb06..147c30a81f15 100644
> --- a/arch/x86/platform/efi/efi.c
> +++ b/arch/x86/platform/efi/efi.c
> @@ -468,7 +468,7 @@ void __init efi_init(void)
>          */
>
>         if (!efi_runtime_supported())
> -               pr_info("No EFI runtime due to 32/64-bit mismatch with ke=
rnel\n");
> +               pr_err("No EFI runtime due to 32/64-bit mismatch with ker=
nel\n");
>
>         if (!efi_runtime_supported() || efi_runtime_disabled()) {
>                 efi_memmap_unmap();
> --
> 2.31.1
>

Queued up now, thanks.