Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210521020051.196434-1-hyc.lee@gmail.com> <87o8d4qxyi.fsf@suse.com>
In-Reply-To: <87o8d4qxyi.fsf@suse.com>
From:   Hyunchul Lee <hyc.lee@gmail.com>
Date:   Sat, 22 May 2021 23:17:31 +0900
Message-ID: <CANFS6bb4AsWjkGCo+pKni_QSCF8M6vFvNiLs--K+2v=zOJ5T_A@mail.gmail.com>
Subject: Re: [PATCH v2] cifs: decoding negTokenInit with generic ASN1 decoder
To:     =?UTF-8?Q?Aur=C3=A9lien_Aptel?= <aaptel@suse.com>
Cc:     Steve French <sfrench@samba.org>,
        David Howells <dhowells@redhat.com>, kernel-team@lge.com,
        Namjae Jeon <linkinjeon@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-cifs <linux-cifs@vger.kernel.org>,
        samba-technical@lists.samba.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Aur=C3=A9lien,

2021=EB=85=84 5=EC=9B=94 21=EC=9D=BC (=EA=B8=88) =EC=98=A4=ED=9B=84 5:43, A=
ur=C3=A9lien Aptel <aaptel@suse.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> Hi Hyunchul,
>
> The existence of multiple ASN1 decoder has been a regular complaint,
> this looks nice. Have you tested it against any servers?
>

Yes, I have tested this patch against Windows 10, Samba 4.11.6, and cifsd.
If you have trouble,  you need to rebuild the kernel due to rebuilding
the OID registry.

> I think we need to make sure it works with Windows Server (including
> increased ones with the increased security flag, Steve do you remember
> the name of that flag?) and Samba at least.
>

If you let me know the option, I will try.

> There is the SDC EMEA plugfest coming up, might be a good time to try it
> out against other vendors as well.
>

Yes, but I am not gonna to attend the plugfest because of personal reasons.
Is there any other way to test this against other vendors?

Thanks,
Hyunchul

> Cheers,
> --
> Aur=C3=A9lien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg,=
 DE
> GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 247165 (AG M=C3=
=BCnchen)
>