Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2477220pxj; Sun, 23 May 2021 01:19:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyD0FHgh1zPGphzCl6sJVeLkbyaxTSNZfnlh1Td3I/g/BWAzlTbSdQ0cXttOfyoXuhGrK81 X-Received: by 2002:a05:6e02:b:: with SMTP id h11mr9242188ilr.18.1621757974710; Sun, 23 May 2021 01:19:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621757974; cv=none; d=google.com; s=arc-20160816; b=I267djCafzgk+R1mj+m/tOikwXxlnB1YR+mxzAJKVmTyjrkx9PsnFACsVIiEQF89Bl pXRuyKW0ZKZPomPWpWrmxTUMazuScvW9GEAqbygm17WIlT1tvlinwXCxwRhrNbAE98FP CNHra865LLfIY/yqVicigvj9ay4ktzbbNc99iPDcHOYmq2d8hvgyc3AhTZOPLBxKjBMk sRCaQ0rMOwhkNNEGm6RoqNhLv1/fwmEcl3pTyI3+Vd1Ti3cYYK+sEIZJFar2U6BOVLOw LmReoJcYHd3kmtOAqJ14ZIWgvKpyJ671fOzTTs0Nc70wyb80TyZBuP0WgcdB4x80aYv7 w5JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=J/tH5Di1hqgJWQ0pbMGlB+pnJ5/27SLTw0y6Yu33wxM=; b=sJL1D+vuCzORfkBazfHCpetQ3/rs3PtFxLtCdQwAcpsHhYg5t1uijFBMiX4RIIjq3m 8rPArna2jPoe60VwxPWM29ON5j+B14sYCs1NrPc9AE+E0MLJnHb+AHH67IkkR51uAP/D V1llwQFwAFZHelH8vn41Sxn6cIN7Rp0MDngDHOvnFbk4B+dGnhsAxoYkDJRV5OmRIDs4 GX5GvI+/LSI5IKzDDO6uqXoHgE6wBabhi9T1RUondq9i3w0fDxb1hoOP06gm0QbRghyg YkvSazJwJXuGdj0lUobrVAhxvIYJkIxh1Ras7CKYN1it2G9hEboYCIYsal2NbTy3/v30 gF0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oPc0pz0d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h5si12955299iol.44.2021.05.23.01.19.20; Sun, 23 May 2021 01:19:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oPc0pz0d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231636AbhEWIUQ (ORCPT + 99 others); Sun, 23 May 2021 04:20:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:40204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231153AbhEWIUP (ORCPT ); Sun, 23 May 2021 04:20:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9AB4961168; Sun, 23 May 2021 08:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621757928; bh=U0YAvZaLR8WDB/++plZoqCKo3gtUlnYXHKAqLTt8gr8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oPc0pz0dEPacRLTt9eTBIWButqRYE/XQ+Jy1WcfgbyZgnRYks466piY9L5/bR52ca 9aXd7M4YiLY3Kqs8xRoBZOX/3BZugaXSjcXKvDS1gWuHbJgppKflry2/6cqDsLRqEU Ji7yLOOTjyrg4dX+q2G94vmxfyVBi5Q22MQ+UtEs= Date: Sun, 23 May 2021 10:18:44 +0200 From: Greg Kroah-Hartman To: Lukas Bulwahn Cc: Jiri Slaby , Ralf Ramsauer , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [RFC PATCH 1/1] MAINTAINERS: TTY LAYER: add some ./include/linux/ header files Message-ID: References: <20210518052117.14819-1-lukas.bulwahn@gmail.com> <20210518052117.14819-2-lukas.bulwahn@gmail.com> <69da627e-91c5-66f0-c0c9-75fbaaba6782@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 23, 2021 at 09:05:48AM +0200, Lukas Bulwahn wrote: > On Tue, May 18, 2021 at 7:37 AM Jiri Slaby wrote: > > > > On 18. 05. 21, 7:21, Lukas Bulwahn wrote: > > > An early prototypical automated code analysis of headers and the > > > existing MAINTAINERS sections identified some header files in > > > ./include/linux/ to be probably included into the TTY LAYER section. > > > > > > I further checked those suggestions by this analysis and identified a > > > subset of files that I am rather certain to belong to the TTY LAYER. > > > > > > Add these ./include/linux/ header files to TTY LAYER in MAINTAINERS. > > > > > > The patterns include/linux/tty*.h and include/linux/vt_*.h currently cover: > > > > > > include/linux/tty.h > > > include/linux/tty_driver.h > > > include/linux/tty_flip.h > > > include/linux/tty_ldisc.h > > > > > > include/linux/vt_buffer.h > > > include/linux/vt_kern.h > > > > Yes, that looks good. > > > > Can you extend the tool to include/uapi too? > > > > For example this is missing too: > > include/uapi/linux/tty*.h > > > > It expands to: > > include/uapi/linux/tty_flags.h > > include/uapi/linux/tty.h > > > > Jiri, > > Greg already picked this patch up; so I will keep this patch as-is and move on. This patch was fine as-is, but sending an additional patch with that information added would be most welcome. No need for your tool to create it, you can do it by hand :) thanks, greg k-h