Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161395AbWJaBFG (ORCPT ); Mon, 30 Oct 2006 20:05:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422775AbWJaBFG (ORCPT ); Mon, 30 Oct 2006 20:05:06 -0500 Received: from smtp.osdl.org ([65.172.181.4]:23695 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1422772AbWJaBFE (ORCPT ); Mon, 30 Oct 2006 20:05:04 -0500 Date: Mon, 30 Oct 2006 17:04:45 -0800 From: Andrew Morton To: Ingo Molnar Cc: Stefan Richter , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.19-rc3] i386/io_apic: fix compiler warning in create_irq Message-Id: <20061030170445.1dedce1e.akpm@osdl.org> In-Reply-To: <20061030090231.GA27146@elte.hu> References: <20061030090231.GA27146@elte.hu> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 29 On Mon, 30 Oct 2006 10:02:31 +0100 Ingo Molnar wrote: > * Stefan Richter wrote: > > > Fix warning > > arch/i386/kernel/io_apic.c: In function `create_irq': > > arch/i386/kernel/io_apic.c:2420: warning: 'vector' might be used uninitialized in this function > > > @@ -2421,6 +2421,7 @@ int create_irq(void) > > unsigned long flags; > > > > irq = -ENOSPC; > > + vector = 0; > > NAK - the code is fine, and this is fixed in Jeff's gcc-warnings tree > via annotation. err, what gcc-warnings tree? git+ssh://master.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git#gccbug just does lots of initialise-to-zero thingies, doesn't have any special annotation and doesn't fix io_apic.c. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/