Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2769167pxj; Sun, 23 May 2021 10:12:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYyScS8xMiYq4P0GBGHoaayUBZAuwbTzFlEAOm97rU8NEv74v+zmhl1Oav9h5Oumu2lQ8O X-Received: by 2002:a05:6638:258c:: with SMTP id s12mr18833081jat.92.1621789947672; Sun, 23 May 2021 10:12:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621789947; cv=none; d=google.com; s=arc-20160816; b=EEPDXTyXQORWCKCNzLxyGfSvVU93MDNYgjBta1ad8dykTcBLXZqp8x9R1stLTB7i34 B/L7HkpY1s0XAMc7GtmqMcU+FUn5plTDyaGtmgoF0BK6aUGQAiGzSAkarvaPCe/VV/Vz UCWaCVDWR7zHasksVSbLHuDFWoxbG9OJfb+hSQkrXCKceC4tECwSjJ5L3a7UHJb6tRCD axIN4PJ0MR+3dRM2CLWAKQRHT1PiafLZ20xSgRN7NT/gQLvoq/XofKFwwaEU7jxDpEme OKa5Yw+cb2rVknCaSP/P1JXjIDlcWr3mp4Uefx4J5kaxXB5JSp072Sux24aMzK4kCn0p cgTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=iwxLYsfnHOmvUnEFzHOLUjQtowCkQzZpZ02r9YeM+9E=; b=OVkYciUihPUIoWWp3RvniGKcDR8yCj3VUOlCzyZEOxS0Y3Vj/LI3m2E7raRa3DiGpv HcxpWZ2E4F5GHKVURCiT/wPvRFvyIUb8iZVk4IYaXLTAP8KleVMhFuYQnP8EFGxpvSqK rQLqhzLVYoGYYBsf8K6Wc0t/Ow/mkKWq+fIN5mKoK/nR+VwXPZDKglzPvmrIZNZFhJeE 3Fmx0/0RyzLifoK+kyCLlwrz56D/UDV+LW8p3PiyIHkBtWokpGdykZC84OV9HqtnMPJ+ Sma/FNA8WCvLhJWE54y2MSI7UmBdFIGINV3Tmqn8B1j5wrgGxQC5l7E8xTiNEABDslSG v14Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UTiwRr5o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si11810412ilq.40.2021.05.23.10.12.14; Sun, 23 May 2021 10:12:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UTiwRr5o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231898AbhEWRNM (ORCPT + 99 others); Sun, 23 May 2021 13:13:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231828AbhEWRNJ (ORCPT ); Sun, 23 May 2021 13:13:09 -0400 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05DA1C061574; Sun, 23 May 2021 10:11:40 -0700 (PDT) Received: by mail-qv1-xf35.google.com with SMTP id w9so13016145qvi.13; Sun, 23 May 2021 10:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=iwxLYsfnHOmvUnEFzHOLUjQtowCkQzZpZ02r9YeM+9E=; b=UTiwRr5o5hHzc6dxrDpEuYbJUd/Wxb7c3vNSqseoDKZkAprP0EsinNkPcvEqH/MtRf VZ0W4kk/h95ARtaM2DQ+f5Octj0jMZpOh4tfXdbCYNr0AfuCdBMW4eQMPUaGaoJaTVdx wuc4TfMTa+CaK82dcKDNctlqL6rCCQfSCCd7HI+sbgr8XvwooRBlEohWrf4OirSDYcgF PAs+hGT4LWyX390+W97wSGKcOCEJXJjGu6sbrPLdcUPv/1E2nSAgSle3Q1QFhIplWDd/ e3E2t2LOUyDauctz8X1umaVVUMo+uaUq3FCM9omM+A1oKlECyu9nRVbvWia/epgJ9t1C tpxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=iwxLYsfnHOmvUnEFzHOLUjQtowCkQzZpZ02r9YeM+9E=; b=EuURJoIUkX5guPMQMFxV4ZQdDSAjs+MAkxSq1PsaR6GAM8bWkoKZ6xzEv5GLbrXIE6 lrHOC5uiym+5O/Ctzr3j/4/hiSPy6RMX2CjjFt6NakOdbn7uNClE7gJEaMUNsUnLNWBe 6JSb+mynECnyXNOI9YiLTVE38ogLitgFkXS8PUG87SziG1uwCvIuIJ9qrFasrWJ+NF9f 89XNY7mqCjEXTaNFUcYKrXv7w6rJS+9llh+76fxKsPTFs1mq6lRT3iZbnjrJwsXQvaJr LybBw7oAipMhjg2y4oELkffJvYLPO6+xrQ7WFi5F4XDr65I4HL39Y6EOnXPzR0pFz20A 7kSQ== X-Gm-Message-State: AOAM532kTB8IwRharrYw3iuB1H3oISd8vtJMaOu2HJyzO8eHmggoQBd1 k3qeGUugn/fPHHwqV88hYMqWauGCUJki1Q3B X-Received: by 2002:ad4:57c4:: with SMTP id y4mr25740110qvx.33.1621789900059; Sun, 23 May 2021 10:11:40 -0700 (PDT) Received: from smtp.gmail.com ([2804:14c:73:9a01::1003]) by smtp.gmail.com with ESMTPSA id k125sm9221718qkf.53.2021.05.23.10.11.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 May 2021 10:11:39 -0700 (PDT) Date: Sun, 23 May 2021 14:11:35 -0300 From: Lucas Stankus To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/3] staging: iio: cdc: ad7746: initial effort to move out of staging Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tidy up driver code by removing vague comments, simplifying probe return, and extracting capdac register write to a separate function. These small patches are a starting point for improving the ad7746 driver, hopefully to a point where it's possible to get it out of staging. I'm looking up to feedback on what could be improved to accomplish that. changelog v1 -> v2: - Dropped num_channels fixup patch (applied from previous series). - Split general code style patch into several atomic ones. - New patch to catch capdac write boilerplate into a single function. Lucas Stankus (3): staging: iio: cdc: ad7746: remove ordinary comments staging: iio: cdc: ad7746: clean up probe return staging: iio: cdc: ad7746: extract capac setup to own function drivers/staging/iio/cdc/ad7746.c | 58 +++++++++++++------------------- 1 file changed, 23 insertions(+), 35 deletions(-) -- 2.31.1