Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Heinrich Schuchardt <xypron.glpk@gmx.de>
To:     linux-kernel@vger.kernel.org
Cc:     Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: [PATCH 1/1] include/linux/byteorder/generic.h: fix index variables
Date:   Sun, 23 May 2021 22:49:57 +0200
Message-Id: <20210523204958.64575-1-xypron.glpk@gmx.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

In cpu_to_be32_array() and be32_to_cpu_array() the length of the array is
given by variable len of type size_t. An index variable of type int is use=
d
to iterate over the array. This is bound to fail for len > INT_MAX and
lets GCC add instructions for sign extension.

Correct the type of the index variable.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
=2D--
 include/linux/byteorder/generic.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/byteorder/generic.h b/include/linux/byteorder/g=
eneric.h
index 4b13e0a3e15b..c9a4c96c9943 100644
=2D-- a/include/linux/byteorder/generic.h
+++ b/include/linux/byteorder/generic.h
@@ -190,7 +190,7 @@ static inline void be64_add_cpu(__be64 *var, u64 val)

 static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t =
len)
 {
-	int i;
+	size_t i;

 	for (i =3D 0; i < len; i++)
 		dst[i] =3D cpu_to_be32(src[i]);
@@ -198,7 +198,7 @@ static inline void cpu_to_be32_array(__be32 *dst, cons=
t u32 *src, size_t len)

 static inline void be32_to_cpu_array(u32 *dst, const __be32 *src, size_t =
len)
 {
-	int i;
+	size_t i;

 	for (i =3D 0; i < len; i++)
 		dst[i] =3D be32_to_cpu(src[i]);
=2D-
2.30.2