Message-ID: <4546B9BC.6020109@in.ibm.com>
Date: Tue, 31 Oct 2006 08:19:32 +0530
From: Balbir Singh <balbir@in.ibm.com>
Reply-To: balbir@in.ibm.com
Organization: IBM
User-Agent: Thunderbird 1.5.0.7 (X11/20060922)
MIME-Version: 1.0
To: Oleg Nesterov <oleg@tv-sign.ru>
CC: Andrew Morton <akpm@osdl.org>, Shailabh Nagar <nagar@watson.ibm.com>,
       Jay Lan <jlan@sgi.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] taskstats_tgid_free: fix usage
References: <20061026232128.GA526@oleg>
In-Reply-To: <20061026232128.GA526@oleg>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 930
Lines: 29

Oleg Nesterov wrote:
> taskstats_tgid_free() is called on copy_process's error path. This is wrong.
> 
> 	IF (clone_flags & CLONE_THREAD)
> 		We should not clear ->signal->taskstats, current uses it,
> 		it probably has a valid accumulated info.
> 	ELSE
> 		taskstats_tgid_init() set ->signal->taskstats = NULL,
> 		there is nothing to free.
> 
> Move the callsite to __exit_signal(). We don't need any locking, entire
> thread group is exiting, nobody should have a reference to soon to be
> released ->signal.
> 
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

Looks good!
Acked-by: Balbir Singh <balbir@in.ibm.com>

---

	Balbir Singh,
	Linux Technology Center,
	IBM Software Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/