Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 23 May 2021 20:52:17 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Dave Jiang <dave.jiang@intel.com>
Cc:     alex.williamson@redhat.com, kwankhede@nvidia.com,
        tglx@linutronix.de, vkoul@kernel.org, megha.dey@intel.com,
        jacob.jun.pan@intel.com, ashok.raj@intel.com, yi.l.liu@intel.com,
        baolu.lu@intel.com, kevin.tian@intel.com, sanjay.k.kumar@intel.com,
        tony.luck@intel.com, dan.j.williams@intel.com,
        eric.auger@redhat.com, pbonzini@redhat.com,
        dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Subject: Re: [PATCH v6 11/20] vfio/mdev: idxd: Add basic driver setup for
 idxd mdev
Message-ID: <20210523235217.GM1002214@nvidia.com>
References: <162164243591.261970.3439987543338120797.stgit@djiang5-desk3.ch.intel.com>
 <162164281350.261970.10539208268885731071.stgit@djiang5-desk3.ch.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <162164281350.261970.10539208268885731071.stgit@djiang5-desk3.ch.intel.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mlx.ziepe.ca (206.223.160.26) by YTBPR01CA0013.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:14::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.27 via Frontend Transport; Sun, 23 May 2021 23:52:18 +0000
Received: from jgg by mlx with local (Exim 4.94)        (envelope-from <jgg@nvidia.com>)        id 1lkxtJ-00DV3U-AN; Sun, 23 May 2021 20:52:17 -0300
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b8e3af91-2933-49ed-4786-08d91e45cce8
X-MS-TrafficTypeDiagnostic: BL1PR12MB5063:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BL1PR12MB506311DC36FAD1E181C0B903C2279@BL1PR12MB5063.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: l79zH9OAhrGDW70bUVxgVdwb0TSDj9AGoRh3OwmaP0YaGLDz0D/mQVj2RIqdMiX8TyW6jJ4H2LlitYKx10T9YkwvdRqbZufAzUpTmXdYtYiJe2yEDQojD4ZF+4z0T9Ji9wQJlQrlxayhJIQrF9fdo+MyK+5b1H8ACz81QQJpi7a2N05ZtwA/hAYBvdjRApDXP+/aiB7LsI1tKZ0xrwwOC3jCuAh0EdISTVZ97nQHLQXtUP2WQNm5gY1uN3iQx76lXQD1aKuAGrLBdrZ4marHIbXPJAWv0FxlrzSUg3HGmftmkf1OKFXryTdF9e3dow27+w7tn7fuNHamS3UTETi740QBo3Xq2Nx+hZpG5O6Tmh8xTsDqitpUZltYC+YvVtml/G+ymOSyHXK55US37DEQH1B2+Mz5EHBYv4K4Hkj/hAB4rdQIY0qPMXIUmeudZwuixHB9aSgZIY4Z12yPtiInq21Uqk1tAHpmKlmIofRIEDivsrABMd1bealigq22pyIAyze5AdBy6nk0f0mPSsw85ICI1QIQRQ8fq3zs/Rr4M+vbM5a9YPEMQ9osvSvDZW+dzuF//OKLMNcSNMR9OE7ZN8OBQDqEJCSb8scqwnn5PJI=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB5506.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(346002)(39860400002)(376002)(136003)(33656002)(86362001)(2616005)(38100700002)(426003)(8936002)(4744005)(2906002)(186003)(4326008)(9746002)(9786002)(316002)(6916009)(478600001)(66556008)(66476007)(8676002)(26005)(7416002)(5660300002)(66946007)(1076003)(36756003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?CBZgo6/uC7HC+WJeW76iQo26g23WsihaC6rLDsAaqn8wiBy7uu7TU95VCO3K?=
 =?us-ascii?Q?boTD+YpraC3cx+Rp0ILp3iFf/UQ2zjLvSj3oovtzKffAX3UOY68IV9JRRSDe?=
 =?us-ascii?Q?tXZGyEriwhhDMOfrtSytEPRTOq5NPfEFHT1fsN4RDnX1ppKZVrcdXTiQqZQT?=
 =?us-ascii?Q?C53FnpuTG5QDi8g/g+JnpRcUeeL3UbQ4G+jhLMrIL0oQMClHl97BjGYnKRRU?=
 =?us-ascii?Q?DQhDmSrTSBUL5+9reqZFAx7UcGlumL91cdIm+qLQPzUVpWXgzPtEAoW9fo8h?=
 =?us-ascii?Q?6A0D3aPkMGdXwSI05ZbZ/x29CfTXK/+MxMnscOwIfDDIltuIGHIxNXG+KPSj?=
 =?us-ascii?Q?4kEIm2NaSnvtQKI1OcgwmAm8Gr76sqLHnAPSjc+WbAAe3XiwSYL/8oVEWIpi?=
 =?us-ascii?Q?hM/yq0+DUsdhycnYn7/48SaShGtq8ByBnJz2ZNCchpAU8ZbVmlCLvjSdsb7K?=
 =?us-ascii?Q?/acPFZLo7XQYnGvk0/Yhc4aTYM8DFnRqBcfCpFi9z3I4ytCjp69ji7aJqY7K?=
 =?us-ascii?Q?6QfwjDD9Q5Wdjh+osAhSzB7mofpnxx0mObxqnMYmQF0bDHbX3liD7+WPiQ6T?=
 =?us-ascii?Q?u3XVCseI1EPTh8C/5BZ+UBf0C68CnbbUGuNA1S7yFSwRAlvV1SXfytMIh1AX?=
 =?us-ascii?Q?pGAKXSRy27I//xWpRp6ff9yvCzbqCc38FeqLvYb/rdAdDodjdLo8HI/qT51F?=
 =?us-ascii?Q?9jr1ukj7Z9diRPduBdGL3AdTK0D9ym73JIQGGKugQp27waycOsq+dQlTYFVq?=
 =?us-ascii?Q?vYPKesODwn8OGDGyCcIPlXI4AkvzIwFfvFSLAQ2SSO5jMpU5yFQ6Jy77TJ6R?=
 =?us-ascii?Q?OUnfosLC8Icdn97OUJKkwpqJwSutm6MeJ7j58UvcDfBOym4s5N1oDxfFk1vI?=
 =?us-ascii?Q?LJR0gKos9WdVrZqf417EMiB2UM7aYgoJCsFApCe32up52iwxIZ/VqDtVCLs8?=
 =?us-ascii?Q?DNDeGXnDV2vNnOOprtsajpxW8IMBv19xPo+jfVqEd0InNiwMsgi5xUJ3QsiP?=
 =?us-ascii?Q?j8QuSw5AcsEWSlJ39vYUTrpw1X+TZ61qn+/srcDFXWIAWyto3mpHFKxNO4o5?=
 =?us-ascii?Q?bLrzzyCmzkE/wukFWJYvWCd0r13fd7HEMu7b8VBOjlmsbjBIrP4cPmokKgl6?=
 =?us-ascii?Q?a1xGDX++kTRu7DbSobWEloTeCncnbW9ixri7zviy9K3M5j5izQU2zRq9w7GN?=
 =?us-ascii?Q?l6yJ2oRFxmRgSYh6mlutbjT4J84RNK9NcpOmyvSU1YUCgnTlXB8XHc3QVGf0?=
 =?us-ascii?Q?8iflY12HksqmJmhhJQcxoFfvaVDrYFhhM4q5C16xMgvU8CHbAaqYc+fGVob+?=
 =?us-ascii?Q?1vVrAMJiik55wdOfPs6jdzsN?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b8e3af91-2933-49ed-4786-08d91e45cce8
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2021 23:52:19.0470
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uEGql0/Nulvuz3Z4KjHxW/bBADjyB0Tgq5/QR3Xif08bwrCIVC86LOZsIh4VsHn4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5063
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 21, 2021 at 05:20:13PM -0700, Dave Jiang wrote:
> +static int idxd_mdev_drv_probe(struct device *dev)
> +{
> +	struct idxd_wq *wq = confdev_to_wq(dev);
> +	struct idxd_device *idxd = wq->idxd;

Something has gone wrong that the probe function for a
idxd_device_driver has this generic signature..

Jason