Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210424004645.3950558-1-seanjc@google.com> <20210424004645.3950558-3-seanjc@google.com>
 <CAAeT=FyNo1CGvnamc3_J9EEQUn6WcdkMp50-QgmLYYVCFA2fZA@mail.gmail.com>
 <YKVdUtvSg7/I7Ses@google.com> <CAAeT=FxvS_hzcZbZQ_jQnWwX+xDT0SqQoHKELeviqu_QvvnbYg@mail.gmail.com>
 <YKfRj+I2Wa+t//lb@google.com>
In-Reply-To: <YKfRj+I2Wa+t//lb@google.com>
From:   Reiji Watanabe <reijiw@google.com>
Date:   Sun, 23 May 2021 21:29:46 -0700
Message-ID: <CAAeT=FxuBEY1C7MMQ5f34-AbQjtDRAgVeR88LkS9=763dCjb=A@mail.gmail.com>
Subject: Re: [PATCH 02/43] KVM: VMX: Set EDX at INIT with CPUID.0x1, Family-Model-Stepping
To:     Sean Christopherson <seanjc@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

> > > On Tue, May 18, 2021, Reiji Watanabe wrote:
> > > > BTW, I would think having a default CPUID for CPUID.(EAX=3D0x1) wou=
ld be better
> > > > for consistency of a vCPU state for RESET.  I would think it doesn'=
t matter
> > > > practically anyway though.
> > >
> > > Probably, but that would require defining default values for all of C=
PUID.0x0 and
> > > CPUID.0x1, which is a can of worms I'd rather not open.  E.g. vendor =
info, basic
> > > feature set, APIC ID, etc... would all need default values.  On the o=
ther hand,
> > > the EDX value stuffing predates CPUID, so using 0x600 isn't provably =
wrong, just
> > > a bit anachronistic. :-)
> >
> > I see... Then I don't think it's worth doing...
> > Just out of curiosity, can't we simply use a vcpu_id for the APIC ID ?
>
> That would mostly work, but theoretically we could overflow the 8 bit fie=
ld
> because max vCPUs is 288.  Thanks Larrabee.
>
>   commit 682f732ecf7396e9d6fe24d44738966699fae6c0
>   Author: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
>   Date:   Tue Jul 12 22:09:29 2016 +0200
>
>     KVM: x86: bump MAX_VCPUS to 288
>
>     288 is in high demand because of Knights Landing CPU.
>     We cannot set the limit to 640k, because that would be wasting space.
>
> > Also, can't we simply use the same values that KVM_GET_SUPPORTED_CPUID
> > provides for other CPUID fields ?
>
> Yes, that would mostly work.  It's certainly possible to have a moderatel=
y sane
> default, but there's essentially zero benefit in doing so since practical=
ly
> speaking all userspace VMMs will override CPUID anyways.  KVM could compl=
etely
> default to the host CPUID, but again, it wouldn't provide any meaningful =
benefit,
> while doing so would step on userspace's toes since KVM's approach is tha=
t KVM is
> "just" an accelerator, while userspace defines the CPU model, devices, et=
c...
> And it would also mean KVM has to start worrying about silly corner cases=
 like
> the max vCPUs thing.  That's why I say it's a can of worms :-)

Ah, I see.  Thank you for the answer and the helpful information !

Regards,
Reiji