Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sanket Parmar <sparmar@cadence.com>
To:     Peter Chen <peter.chen@kernel.org>,
        Pawel Laszczak <pawell@cadence.com>
CC:     "a-govindraju@ti.com" <a-govindraju@ti.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rahul Kumar <kurahul@cadence.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "kishon@ti.com" <kishon@ti.com>
Subject: RE: [PATCH] usb: cdns3: Enable TDL_CHK only for OUT ep
Thread-Topic: [PATCH] usb: cdns3: Enable TDL_CHK only for OUT ep
Thread-Index: AQHXSy488vN61g59eEq3SQd4c6aFyqrvTquAgALMHDA=
Date:   Mon, 24 May 2021 05:39:22 +0000
Message-ID: <BY5PR07MB81192669816D2F08D4AEAD1EB0269@BY5PR07MB8119.namprd07.prod.outlook.com>
References: <1621263912-13175-1-git-send-email-sparmar@cadence.com>
 <20210522100913.GB12415@b29397-desktop>
In-Reply-To: <20210522100913.GB12415@b29397-desktop>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d0c5666-fdfd-4711-c58a-08d91e7648e4
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2021 05:39:22.6268
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wRI9SActBfjUtuQQqQsMM0Zj8SjFmuoihek3TRAcyFK0OkYkBuJh/nEvO3rBFpUvMjxrT7nJeBGwWmfvT++Knj+GWDDSPoobWD0+LlJ2E+4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4856
X-Proofpoint-ORIG-GUID: Gw66BYNjdsbvRhPNiGtviHrlCe5TViRp
X-Proofpoint-GUID: Gw66BYNjdsbvRhPNiGtviHrlCe5TViRp
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-05-24_02:2021-05-20,2021-05-24 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0
 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 mlxlogscore=999
 impostorscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2105240042
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On 21-05-17 17:05:12, Sanket Parmar wrote:
> > ZLP gets stuck if TDL_CHK bit is set and TDL_FROM_TRB is used
> > as TDL source for IN endpoints. To fix it, TDL_CHK is only
> > enabled for OUT endpoints.
> >
> > Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
> > Reported-by: Aswath Govindraju <a-govindraju@ti.com>
> > Signed-off-by: Sanket Parmar <sparmar@cadence.com>
> > ---
> >  drivers/usb/cdns3/cdns3-gadget.c |    8 +++-----
> >  1 files changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3=
-
> gadget.c
> > index 105855a..f3c0276 100644
> > --- a/drivers/usb/cdns3/cdns3-gadget.c
> > +++ b/drivers/usb/cdns3/cdns3-gadget.c
> > @@ -2007,7 +2007,7 @@ static void cdns3_configure_dmult(struct
> cdns3_device *priv_dev,
> >  		else
> >  			mask =3D BIT(priv_ep->num);
> >
> > -		if (priv_ep->type !=3D USB_ENDPOINT_XFER_ISOC) {
> > +		if (priv_ep->type !=3D USB_ENDPOINT_XFER_ISOC  && !priv_ep-
> >dir) {
> >  			cdns3_set_register_bit(&regs->tdl_from_trb, mask);
> >  			cdns3_set_register_bit(&regs->tdl_beh, mask);
> >  			cdns3_set_register_bit(&regs->tdl_beh2, mask);
> > @@ -2046,15 +2046,13 @@ int cdns3_ep_config(struct cdns3_endpoint
> *priv_ep, bool enable)
> >  	case USB_ENDPOINT_XFER_INT:
> >  		ep_cfg =3D EP_CFG_EPTYPE(USB_ENDPOINT_XFER_INT);
> >
> > -		if ((priv_dev->dev_ver =3D=3D DEV_VER_V2 && !priv_ep->dir) ||
> > -		    priv_dev->dev_ver > DEV_VER_V2)
> > +		if (priv_dev->dev_ver >=3D DEV_VER_V2 && !priv_ep->dir)
> >  			ep_cfg |=3D EP_CFG_TDL_CHK;
> >  		break;
> >  	case USB_ENDPOINT_XFER_BULK:
> >  		ep_cfg =3D EP_CFG_EPTYPE(USB_ENDPOINT_XFER_BULK);
> >
> > -		if ((priv_dev->dev_ver =3D=3D DEV_VER_V2  && !priv_ep->dir) ||
> > -		    priv_dev->dev_ver > DEV_VER_V2)
> > +		if (priv_dev->dev_ver >=3D DEV_VER_V2 && !priv_ep->dir)
> >  			ep_cfg |=3D EP_CFG_TDL_CHK;
> >  		break;
> >  	default:
> > --
>=20
> Sanket & Pawel, please confirm this behaviour could apply for DEV_VER_V3,
> that is TDL_CHK can't be used for bulk in for DEV_VER_V3?

Yes, TDL_CHK shouldn't be used for bulk in for DEV_VER_V3.

>=20
> --
>=20
> Thanks,
> Peter Chen