Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <4189cb2094b4fe43e351eb1d80ca6c4cb1ac08ed.camel@fi.rohmeurope.com>
Subject: Re: [PATCH 1/2] regulator: bd70528: Fix off-by-one for buck123
 .n_voltages setting
From:   Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Reply-To: matti.vaittinen@fi.rohmeurope.com
To:     Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc:     Lee Jones <lee.jones@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org, linux-power@fi.rohmeurope.com
In-Reply-To: <20210523071045.2168904-1-axel.lin@ingics.com>
References: <20210523071045.2168904-1-axel.lin@ingics.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-Z/tvXtdc/nBXr/Xk8oWz"
MIME-Version: 1.0
Date:   Mon, 24 May 2021 08:41:06 +0300
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
Precedence: bulk


--=-Z/tvXtdc/nBXr/Xk8oWz
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Axel,

On Sun, 2021-05-23 at 15:10 +0800, Axel Lin wrote:
> The valid selectors for bd70528 bucks are 0 ~ 0xf, so the .n_voltages
> should be 16 (0x10). Use 0x10 to make it consistent with
> BD70528_LDO_VOLTS.
> Also remove redundant defines for BD70528_BUCK_VOLTS.
>=20
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> I think this fix does not need "Fixes" tag because in original code
> the
> .n_voltage is greater than correct one. The latest selector is not
> valid
> in the linear range setting anyway.
>  include/linux/mfd/rohm-bd70528.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/include/linux/mfd/rohm-bd70528.h
> b/include/linux/mfd/rohm-bd70528.h
> index a57af878fd0c..4a5966475a35 100644
> --- a/include/linux/mfd/rohm-bd70528.h
> +++ b/include/linux/mfd/rohm-bd70528.h
> @@ -26,9 +26,7 @@ struct bd70528_data {
>  	struct mutex rtc_timer_lock;
>  };
> =20
> -#define BD70528_BUCK_VOLTS 17
> -#define BD70528_BUCK_VOLTS 17
> -#define BD70528_BUCK_VOLTS 17
> +#define BD70528_BUCK_VOLTS 0x10

Thank you for fixing this. There really is only 16 valid voltage
settings as you pointed out. Regarding changing the define to hex - I
would prefer seeing the amount in decimal as it is easier to
understand. (I do understand bit-patterns better when in HEX - but
"real world" values like voltages, currents or amounts are easier (for
me) to understand when in decimals)


Best Regards
	Matti Vaittinen

--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland
SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~

Simon says - in Latin please.
"non cogito me" dixit Rene Descarte, deinde evanescavit

(Thanks for the translation Simon)


--=-Z/tvXtdc/nBXr/Xk8oWz
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmCrO+4ACgkQeFA3/03a
ocUNzgf/WzIbFrWfqNJSWU3lwmiK+oTqb1gEzPyfcQre72MJlXMyuO8KuV71Z9dJ
jWpID+U/0/WWzmJXOwY00NKhLcUFxsC7kzOCkfd9oCQtiDL1yxGtcEn+1hVkcUTL
08PZ4TWB8K69AyPqM8URtACy7/Yi3b3j4cNj99uVgzbQO71PyMpTXQx4nQsT2eSr
0GNLotITY4KCLBmLN0PsForXF6yrKf3v5BcvGM0mc6cKmGPeHzQzJtCEKQDO7IQk
k2tMZL5wZJ8ftWdMkcJ3di7zNQ+gstSETO12KbI7nxY2wcnyXBiLZAS+BVscZ7s5
eTq+YsBxsLErFrU7lNiHxPZWZ0yURw==
=03ou
-----END PGP SIGNATURE-----

--=-Z/tvXtdc/nBXr/Xk8oWz--