Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 32bSaxDLd4x7cF8zHkGSd9EUYybpnze77BLzKv+O0VVJYjueD9iICJKaDwOQlkNr10YZtWGgC5
 aFO+EJwq0k3g==
IronPort-SDR: rB0cJg0zNoe7UcxKKtzFqnieMtgeEvNXAV1KYWXiZILMuNvfxJadrLmpqlhbLOo01pxRbRUcJ/
 fh6vzNWcDGLg==
Date:   Mon, 24 May 2021 13:59:39 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     David Rientjes <rientjes@google.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Michal Hocko <mhocko@kernel.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Dave Hansen <dave.hansen@intel.com>,
        Ben Widawsky <ben.widawsky@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Dan Williams <dan.j.williams@intel.com>, ying.huang@intel.com
Subject: Re: [RFC Patch v2 2/4] mm/mempolicy: unify the preprocessing for
 mbind and set_mempolicy
Message-ID: <20210524055939.GB48704@shbuild999.sh.intel.com>
References: <1621499404-67756-1-git-send-email-feng.tang@intel.com>
 <1621499404-67756-3-git-send-email-feng.tang@intel.com>
 <7a58082-eb68-744c-93b7-1a688b3b27a@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7a58082-eb68-744c-93b7-1a688b3b27a@google.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Sun, May 23, 2021 at 10:16:11PM -0700, David Rientjes wrote:
> On Thu, 20 May 2021, Feng Tang wrote:
> 
> > Currently the kernel_mbind() and kernel_set_mempolicy() do almost
> > the same operation for parameter sanity check and preprocessing.
> > 
> > Add a macro to unify the code to reduce the redundancy, and make
> > it easier for changing the pre-processing code in future.
> > 
> > Signed-off-by: Feng Tang <feng.tang@intel.com>
> > ---
> >  mm/mempolicy.c | 46 +++++++++++++++++++---------------------------
> >  1 file changed, 19 insertions(+), 27 deletions(-)
> > 
> > diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> > index 1964cca..0f5bf60 100644
> > --- a/mm/mempolicy.c
> > +++ b/mm/mempolicy.c
> > @@ -1460,25 +1460,29 @@ static int copy_nodes_to_user(unsigned long __user *mask, unsigned long maxnode,
> >  	return copy_to_user(mask, nodes_addr(*nodes), copy) ? -EFAULT : 0;
> >  }
> >  
> > +#define MPOL_PRE_PROCESS() \
> 
> This should be extracted to helper function returning bool, not a macro.

Yes, initially I did try it with an inline function, but as a function
it has quite several input parameters and several output parameters, 
which made the code still big and ugly.

But if community think it's the right direction to go, I can change it.

Thanks,
Feng

> > +	 \
> > +	nodemask_t nodes; \
> > +	int err; \
> > +	unsigned short mode_flags; \
> > +	mode_flags = mode & MPOL_MODE_FLAGS; \
> > +	mode &= ~MPOL_MODE_FLAGS; \
> > +	if (mode >= MPOL_MAX) \
> > +		return -EINVAL; \
> > +	if ((mode_flags & MPOL_F_STATIC_NODES) && \
> > +		(mode_flags & MPOL_F_RELATIVE_NODES)) \
> > +		return -EINVAL; \
> > +	err = get_nodes(&nodes, nmask, maxnode); \
> > +	if (err) \
> > +		return err;
> > +
> >  static long kernel_mbind(unsigned long start, unsigned long len,
> >  			 unsigned long mode, const unsigned long __user *nmask,
> >  			 unsigned long maxnode, unsigned int flags)
> >  {
> > -	nodemask_t nodes;
> > -	int err;
> > -	unsigned short mode_flags;
> > +	MPOL_PRE_PROCESS();
> >  
> >  	start = untagged_addr(start);
> > -	mode_flags = mode & MPOL_MODE_FLAGS;
> > -	mode &= ~MPOL_MODE_FLAGS;
> > -	if (mode >= MPOL_MAX)
> > -		return -EINVAL;
> > -	if ((mode_flags & MPOL_F_STATIC_NODES) &&
> > -	    (mode_flags & MPOL_F_RELATIVE_NODES))
> > -		return -EINVAL;
> > -	err = get_nodes(&nodes, nmask, maxnode);
> > -	if (err)
> > -		return err;
> >  	return do_mbind(start, len, mode, mode_flags, &nodes, flags);
> >  }
> >  
> > @@ -1493,20 +1497,8 @@ SYSCALL_DEFINE6(mbind, unsigned long, start, unsigned long, len,
> >  static long kernel_set_mempolicy(int mode, const unsigned long __user *nmask,
> >  				 unsigned long maxnode)
> >  {
> > -	int err;
> > -	nodemask_t nodes;
> > -	unsigned short flags;
> > -
> > -	flags = mode & MPOL_MODE_FLAGS;
> > -	mode &= ~MPOL_MODE_FLAGS;
> > -	if ((unsigned int)mode >= MPOL_MAX)
> > -		return -EINVAL;
> > -	if ((flags & MPOL_F_STATIC_NODES) && (flags & MPOL_F_RELATIVE_NODES))
> > -		return -EINVAL;
> > -	err = get_nodes(&nodes, nmask, maxnode);
> > -	if (err)
> > -		return err;
> > -	return do_set_mempolicy(mode, flags, &nodes);
> > +	MPOL_PRE_PROCESS();
> > +	return do_set_mempolicy(mode, mode_flags, &nodes);
> >  }
> >  
> >  SYSCALL_DEFINE3(set_mempolicy, int, mode, const unsigned long __user *, nmask,
> > -- 
> > 2.7.4
> > 
> >