Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3181975pxj; Mon, 24 May 2021 00:10:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFI2gFd77x1YsgPcKpuA+/ngPulm4fLHWfrtcYRoUgn4giRj0IQ6vLHEIJJ/TBTUusAfz9 X-Received: by 2002:a05:6e02:118b:: with SMTP id y11mr16524201ili.241.1621840219837; Mon, 24 May 2021 00:10:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621840219; cv=none; d=google.com; s=arc-20160816; b=kQUd39/MRgpu157IpawINVPRwER7VtDUXa5F10QDVT2Rh7EVBCmSA64Vn8EpJk5Xg2 ZVDGPPToX95eyGO5wmxIQLJF4Ruq68TYPjelmua68s+x6WKUrEV2zF5IwJEIDuYY9xr/ PpSQENdVg661RLJzpyNZK1kBmJZZiklZap3nv6drabpD2C+6/huLj+B3Q32z/mz54uBP 5luX1BLN8rWAVP+pZ+ODjf3Bcc4WAyljeSkmuywGpmoq85t3079jhBfCs/gLZWdDaD/v Q5qHDf3554VNcj+TeQEes7XG8JdZSUzEItlP+zkkt8YsN1iwOK0GLGHUajzQtfhcWF1l awtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9VOpo/gHkPHwDgSw3ZhANDpZfMVfXF4V6q1iJAhLEPc=; b=efN2nXuaU87uJ3kE4xh0JN26kVWxGQWRWlI8NrAvgWfMUDn5e5NlyrJvI23Sz2B8z4 riFAw86+iS7iP7Dil3Z/cSUcb6G/32gghWuejc2v8WXGuRYZVL4B+VXfQs91zAAt0ID8 DF1TTOqMga7bI5DBCCMQXv6A2t/wnbA7dOgDTjCwWZoBGdglA18DRhVKLMxPqkYgJ4di MEiksxSZKxkhppB7NCgdk62SeKrFP/A2rX7/JZtLgDEzfXlIYQkHS4BuzapKIQ7bDqjl KdawT248a14y+GsGUKRQInbSm20/NdOSZ+PZyY9V04kdgV9KcNbsbxbEMOJ35Ov4qTDE 7pvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bi4lQpje; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s8si15070005ilt.116.2021.05.24.00.10.06; Mon, 24 May 2021 00:10:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bi4lQpje; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232339AbhEXHKd (ORCPT + 99 others); Mon, 24 May 2021 03:10:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:34658 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232128AbhEXHKd (ORCPT ); Mon, 24 May 2021 03:10:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B44A7610A2; Mon, 24 May 2021 07:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621840145; bh=ZTCeoX6bI6iK6W1/fcR9kYUyPM3BV209WtHYQ4y47Qk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bi4lQpjeFtSZnlSpYfhXlIqeDl408KVXI7zYuk6KU/LdX+uoD0QFDRIOnCkLT1Buf 0Wm0FO3PlgN896McWQ3J9PoPw/ZGXKlr1Dy+f6Ntqodz9rzHs9lk9SYJ4B5A8rOo/H lY6oYIduGTCRQMYJr3MXNGM+5SOfXBq1kniD5rlY= Date: Mon, 24 May 2021 09:09:03 +0200 From: Greg KH To: nizamhaider786@gmail.com Cc: laforge@gnumonks.org, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] char: pcmcia: cm4040_cs: Fix failure handling Handled failure cases of device_create() Message-ID: References: <20210523193029.3178-1-nizamhaider786@gmail.com> <20210523193029.3178-2-nizamhaider786@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210523193029.3178-2-nizamhaider786@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 24, 2021 at 01:00:29AM +0530, nizamhaider786@gmail.com wrote: > From: Nijam Haider > > Signed-off-by: Nijam Haider > --- > drivers/char/pcmcia/cm4040_cs.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/pcmcia/cm4040_cs.c b/drivers/char/pcmcia/cm4040_cs.c > index d5e4360..30bb977 100644 > --- a/drivers/char/pcmcia/cm4040_cs.c > +++ b/drivers/char/pcmcia/cm4040_cs.c > @@ -558,6 +558,7 @@ static void reader_release(struct pcmcia_device *link) > static int reader_probe(struct pcmcia_device *link) > { > struct reader_dev *dev; > + struct device *dev_ret; > int i, ret; > > for (i = 0; i < CM_MAX_DEV; i++) { > @@ -593,8 +594,15 @@ static int reader_probe(struct pcmcia_device *link) > return ret; > } > > - device_create(cmx_class, NULL, MKDEV(major, i), NULL, "cmx%d", i); > - > + dev_ret = device_create(cmx_class, NULL, MKDEV(major, i), NULL, "cmx%d", i); > + if (IS_ERR(dev_ret)) { > + printk(KERN_ERR "device_create failed for %d\n", > + i); > + reader_release(link); > + dev_table[i] = NULL; > + kfree(dev); > + return -ENODEV; > + } > return 0; > } > > -- > 2.7.4 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot