Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 24 May 2021 09:10:02 +0200
From:   Lubomir Rintel <lkundrak@v3.sk>
To:     nizamhaider786@gmail.com
Cc:     arnd@arndb.de, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] char: pcmcia: scr24x_cs: Fix redundant fops Removed
 redundant fops assignment, which was already done in cdev_init()
Message-ID: <YKtRSiVK1QEJasP+@demiurge.local>
References: <20210523151111.2968-1-nizamhaider786@gmail.com>
 <20210523151111.2968-2-nizamhaider786@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210523151111.2968-2-nizamhaider786@gmail.com>
Precedence: bulk

On Sun, May 23, 2021 at 08:41:11PM +0530, nizamhaider786@gmail.com wrote:
> From: Nijam Haider <nizamhaider786@gmail.com>
> 

Thank you for this. Needs another spin though:

> Subject: [PATCH 2/2] char: pcmcia: scr24x_cs: Fix redundant fops Removed
                                                                  ^
It seems like you accidentally removed a line break here ---------|,
squishing the subject and patch description together.

>  redundant fops assignment, which was already done in cdev_init()

Regards,
Lubo

> Signed-off-by: Nijam Haider <nizamhaider786@gmail.com>
> ---
>  drivers/char/pcmcia/scr24x_cs.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/pcmcia/scr24x_cs.c b/drivers/char/pcmcia/scr24x_cs.c
> index cad1990..0265d72 100644
> --- a/drivers/char/pcmcia/scr24x_cs.c
> +++ b/drivers/char/pcmcia/scr24x_cs.c
> @@ -266,7 +266,6 @@ static int scr24x_probe(struct pcmcia_device *link)
>  
>  	cdev_init(&dev->c_dev, &scr24x_fops);
>  	dev->c_dev.owner = THIS_MODULE;
> -	dev->c_dev.ops = &scr24x_fops;
>  	ret = cdev_add(&dev->c_dev, MKDEV(MAJOR(scr24x_devt), dev->devno), 1);
>  	if (ret < 0)
>  		goto err;
> -- 
> 2.7.4
>