Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3323085pxj; Mon, 24 May 2021 04:11:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFpGYh54VnSBWAHFQtfeoTBWvkqe3oz09cUPa/cAFKTxfioTMR3MSdY+c7wDapjGWhWwiR X-Received: by 2002:a05:6402:2548:: with SMTP id l8mr25734543edb.208.1621854677153; Mon, 24 May 2021 04:11:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621854677; cv=none; d=google.com; s=arc-20160816; b=sWdr11K2j1QlALNr+pjbVAqmjAesWEjlhQxqGOOSyf4eO+EIma672lI8XmdKCPgIpy xshWSe+FHRTO8xShU7HUhCWHviBmlp1nhdn3+o59QByHGiVH7VlcZv8h4AX+gUTCuc1i p+fe4AX40BKTcznCiGG8PwfIxko5DMxupRz06y5m5ctuVUgsMIi/ykG8Cqq0alWD+v+B bkQHEO2OfL4WobruHJY2tfZ4qlJq+YhC5E2rVlyFItpThebSwkCSBN3IaH2ffkmXmERN h/Pv7uic9r5zPMlfxcAce9r6gBt3ZgvkFP8dC6382YmdpFcHNJdXbwclQFuGsAJEeUi+ BriQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3eoeaEYlJEdc9vwqj9LIiGeXgQo0qXLABwjaPLUWLZc=; b=Tylfv/JYw0s5HHhBD37/AXKspdjxo79NBV8mxxHreuFEhm2kTLjszrGXkavO+Vh9Z7 MzPXBQoCUc4sJRwJ8R1IemH33Y9FI65yizqGLGCASt4MLgx9o8MfUhkdY2jwqnRt2FQM VtH8cq0yMqiTNOhKH41od8TGLjDikJrzxBrnDIczlGxJS/X9I5UWtFdsHDtshlnCp0rr 9V+ff0Naw98MQaIrUUNKpsJ9YEj4dJPnY0Bk6G8VI2qERn4XqiDQYCm0wPCxReQ90ElJ X0mQo84ddw6C3KchVdNtLQT9OAGyuWQPqIFs1Jw7Wck9qNykauHZByluJLXvV/zqhsG0 69+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="R7Monon/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h8si11870029edz.104.2021.05.24.04.10.53; Mon, 24 May 2021 04:11:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="R7Monon/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232744AbhEXLLN (ORCPT + 99 others); Mon, 24 May 2021 07:11:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:36694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232733AbhEXLLK (ORCPT ); Mon, 24 May 2021 07:11:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 85E5661151; Mon, 24 May 2021 11:09:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621854582; bh=LjBPzHdi1VU5NCGXGexHmi9kLJgLIN8NjpuFdA8BasA=; h=From:To:Cc:Subject:Date:From; b=R7Monon/ROGBciX//tUf1cJxXDrjE12vb/BalO2Y3IATvVItA2QtGp0jmRqRPew11 SzT88VYq8sNTD/su/yR5kEJYGq9eJo4FLVK0zbd8rY/EEy1/pjmXCoBlrZLnpB2HsI 8MtngDsywFxwBBgzhwfX0Oytd0ewvWi9YF4lv7DWXIN13zCMiuGsUTc7hrQlexOseg 8njbPZF7xZ8Wzmfwi+Dc7LDUrmJf0mReVuE3calqqOSawMZNhaPAfpbfiNNBNYNd2W zr8VgHDnVu4b2fTVlguX6ShXxWu6iec8QQYFnG1cRG9XTO3mHwibkae6/aEzltPvKn 1rF4yNtb8RhHg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1ll8Sp-0006Pn-7F; Mon, 24 May 2021 13:09:39 +0200 From: Johan Hovold To: Mauro Carvalho Chehab Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 0/3] media: fix zero-length USB control requests Date: Mon, 24 May 2021 13:09:17 +0200 Message-Id: <20210524110920.24599-1-johan@kernel.org> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The direction of the pipe argument must match the request-type direction bit or control requests may fail depending on the host-controller-driver implementation. Control transfers without a data stage are treated as OUT requests by the USB stack and should be using usb_sndctrlpipe(). Failing to do so will now trigger a warning. This series fixes the three media drivers that got this wrong. Johan Johan Hovold (3): media: gspca/gl860: fix zero-length control requests media: gspca/sunplus: fix zero-length control requests media: rtl28xxu: fix zero-length control request drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 3 ++- drivers/media/usb/gspca/gl860/gl860.c | 4 ++-- drivers/media/usb/gspca/sunplus.c | 8 ++++++-- 3 files changed, 10 insertions(+), 5 deletions(-) -- 2.26.3