Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] mm/dmapool: use DEVICE_ATTR_RO macro
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
References: <20210523064626.41532-1-yuehaibing@huawei.com>
 <YKuD4rturdqC6oZF@smile.fi.intel.com>
From:   YueHaibing <yuehaibing@huawei.com>
Message-ID: <3c79a2e6-4560-b417-9a11-b5baa5f28a25@huawei.com>
Date:   Mon, 24 May 2021 19:25:24 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <YKuD4rturdqC6oZF@smile.fi.intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021/5/24 18:45, Andy Shevchenko wrote:
> On Sun, May 23, 2021 at 02:46:26PM +0800, YueHaibing wrote:
>> Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR,
>> which makes the code a bit shorter and easier to read.
> 
> DEVICE_ATTR_RO()
> DEVICE_ATTR()
> 
> After addressing above and below,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Ok, will send v2.
> 
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  mm/dmapool.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/mm/dmapool.c b/mm/dmapool.c
>> index 16483f86360e..62083ef04878 100644
>> --- a/mm/dmapool.c
>> +++ b/mm/dmapool.c
>> @@ -62,8 +62,8 @@ struct dma_page {		/* cacheable header for 'allocation' bytes */
>>  static DEFINE_MUTEX(pools_lock);
>>  static DEFINE_MUTEX(pools_reg_lock);
>>  
>> -static ssize_t
>> -show_pools(struct device *dev, struct device_attribute *attr, char *buf)
>> +static ssize_t pools_show(struct device *dev,
>> +			  struct device_attribute *attr, char *buf)
>>  {
>>  	unsigned temp;
>>  	unsigned size;
> 
> Unrelated change.

There change show_pools() to pools_show()

> 
>> @@ -103,7 +103,7 @@ show_pools(struct device *dev, struct device_attribute *attr, char *buf)
>>  	return PAGE_SIZE - size;
>>  }
>>  
>> -static DEVICE_ATTR(pools, 0444, show_pools, NULL);
>> +static DEVICE_ATTR_RO(pools);
>>  
>>  /**
>>   * dma_pool_create - Creates a pool of consistent memory blocks, for dma.
>> -- 
>> 2.17.1
>>
>