Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <6d5b7b678d68f04e16d3fdc92e2de860135300fc.camel@svanheule.net>
Subject: Re: [PATCH v3 4/6] mfd: Add RTL8231 core device
From:   Sander Vanheule <sander@svanheule.net>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Michael Walle <michael@walle.cc>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Linux LED Subsystem <linux-leds@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
Date:   Mon, 24 May 2021 13:41:36 +0200
In-Reply-To: <CAHp75VfVNJSuiErRYNLvUrCytWXwzos5Uj87Hj+bSBee7p2YfQ@mail.gmail.com>
References: <cover.1621809029.git.sander@svanheule.net>
         <6d14b72bc545a818675d99c8e91e99c96cc3e286.1621809029.git.sander@svanheule.net>
         <CAHp75VcbRKGYSJZK_Rg969-Uck=h+8byWt0B3MtQJDqwbdf2sw@mail.gmail.com>
         <cb8593ab7a70528528bae3de45e33fae68a9ec1c.camel@svanheule.net>
         <CAHp75VfVNJSuiErRYNLvUrCytWXwzos5Uj87Hj+bSBee7p2YfQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 2021-05-24 at 13:18 +0300, Andy Shevchenko wrote:
> On Mon, May 24, 2021 at 11:23 AM Sander Vanheule <sander@svanheule.net> wrote:
> > On Mon, 2021-05-24 at 11:02 +0300, Andy Shevchenko wrote:
> > > On Mon, May 24, 2021 at 1:34 AM Sander Vanheule <sander@svanheule.net>
> > > wrote:
> 
> ...
> 
> > > > +       usleep_range(1000, 10000);
> > > 
> > > It's strange to see this big range of minimum and maximum sleep.
> > > Usually the ratio should not be bigger than ~3-4 between the values.
> > 
> > I could also change this from a usleep to a polling loop that checks (with a
> > loop limit) if the reset bit has self-cleared already.
> > 
> > The datasheet that I have doesn't mention how fast it should self-clear. So
> > I
> > checked, and it appears to be done after one loop iteration already. So,
> > certainly faster than the current usleep.
> > 
> > Would a polling loop (with maybe like max. 10 iterations) be a good
> > alternative
> > for you?
> 
> I guess it's the right way to go. Just check the iopoll.h for helpers.
> Also regmap has regmap_read_poll_timeout().

Thanks for the pointers. Replaced the usleep by regmap_read_poll_timeout.


Best,
Sander