Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3353286pxj; Mon, 24 May 2021 04:57:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpDIhaMgFK5IhPRNLXsYFs47GMsNmynC0WEYnFzqdmuax/A/r7Q3i2m/mXXv7Uwg121I0l X-Received: by 2002:a05:6602:2d8f:: with SMTP id k15mr15515623iow.114.1621857425880; Mon, 24 May 2021 04:57:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621857425; cv=none; d=google.com; s=arc-20160816; b=QsnSuiXmVHXl4WuoY+ald2qM/QGlx5BTAsWbR/Mc+TuL/upjjmX+LMwk6AXq9uu2rv TYBSazLPVoT8BfBSfRA108sNp/dKN0Y3J4TEP5ZOZzplUSXHu1Tm77W2PB4uI71uLEJn IqW1Wvd2JFBt9dvniMuNRqccqODdSSxTiVyah6FQm2lLw3O2LInRbMQ7xcEAdOfTN343 swds7Dv7IpD6QLIOCuabBvEhSMyGiGXyeZ/p30JhbdWewebfq7Sz4dxCGHFFgp8GZp/r /rNJwwsjjfRoNK8lNIHp3ibl0hAyGezQBtU7Jmz/F/3rZ5dsYOgALkBUWHdpXDFAFXdU N6MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=Ysz7saqJvoWxb6UsN8RqIikhzMam/lDtb0r79XvlGtM=; b=GZIxCSqlV5DLm8BWxxgj9u3XdR1YxHFZpCt457pp3CXTIU0yVnqs2FyTf08Q03+2LQ xEjdxPxcHddCAjGv8guXFdlB6JH/BQTwvBKvANJZBjqfTB/IxUxNdMh3VmgAJE+lzsZV AZhRaVdCidpKAjTPSbsdsLE3rILj6h+aJY1FYGPQXE5LHFSW89N/HdcBYPFOmYdJOB71 MOrGtqjXyR4EGBbEOoG97cygpCW1l/4B8aHnrce0PryeyZD7XmgqfBqXJ1awyejwmire YeUxlEdCG1VVWKcBpwwcaBS7cwgYIV1fORxb/0nafLcurHDwA/CTDM+PxRRWnZdwCcSI dBOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t1si8570066ile.141.2021.05.24.04.56.53; Mon, 24 May 2021 04:57:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232553AbhEXL4n (ORCPT + 99 others); Mon, 24 May 2021 07:56:43 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:3980 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232476AbhEXL4m (ORCPT ); Mon, 24 May 2021 07:56:42 -0400 Received: from dggems701-chm.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FpbF13prHzmb0s; Mon, 24 May 2021 19:52:53 +0800 (CST) Received: from dggema769-chm.china.huawei.com (10.1.198.211) by dggems701-chm.china.huawei.com (10.3.19.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 24 May 2021 19:55:12 +0800 Received: from localhost (10.174.179.215) by dggema769-chm.china.huawei.com (10.1.198.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 24 May 2021 19:55:12 +0800 From: YueHaibing To: , , , , , , , CC: , Subject: [PATCH -next] ASoC: Intel: Skylake: use DEVICE_ATTR_RO macro Date: Mon, 24 May 2021 19:55:06 +0800 Message-ID: <20210524115506.35724-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggema769-chm.china.huawei.com (10.1.198.211) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use DEVICE_ATTR_RO() helper instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read. Signed-off-by: YueHaibing --- sound/soc/intel/skylake/skl-nhlt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/intel/skylake/skl-nhlt.c b/sound/soc/intel/skylake/skl-nhlt.c index 87c891c46291..64226072f0ee 100644 --- a/sound/soc/intel/skylake/skl-nhlt.c +++ b/sound/soc/intel/skylake/skl-nhlt.c @@ -149,8 +149,8 @@ int skl_nhlt_update_topology_bin(struct skl_dev *skl) return 0; } -static ssize_t skl_nhlt_platform_id_show(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t platform_id_show(struct device *dev, + struct device_attribute *attr, char *buf) { struct pci_dev *pci = to_pci_dev(dev); struct hdac_bus *bus = pci_get_drvdata(pci); @@ -166,7 +166,7 @@ static ssize_t skl_nhlt_platform_id_show(struct device *dev, return sprintf(buf, "%s\n", platform_id); } -static DEVICE_ATTR(platform_id, 0444, skl_nhlt_platform_id_show, NULL); +static DEVICE_ATTR_RO(platform_id); int skl_nhlt_create_sysfs(struct skl_dev *skl) { -- 2.17.1