Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 0/7] Lazily allocate memslot rmaps
To:     Ben Gardon <bgardon@google.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc:     Peter Xu <peterx@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Peter Shier <pshier@google.com>,
        Yulei Zhang <yulei.kernel@gmail.com>,
        Wanpeng Li <kernellwp@gmail.com>,
        Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
        Kai Huang <kai.huang@intel.com>,
        Keqian Zhu <zhukeqian1@huawei.com>,
        David Hildenbrand <david@redhat.com>
References: <20210518173414.450044-1-bgardon@google.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <85bdd768-d7a3-100c-aade-ef5910b6e729@redhat.com>
Date:   Mon, 24 May 2021 14:43:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210518173414.450044-1-bgardon@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/05/21 19:34, Ben Gardon wrote:
> This series enables KVM to save memory when using the TDP MMU by waiting
> to allocate memslot rmaps until they are needed. To do this, KVM tracks
> whether or not a shadow root has been allocated. In order to get away
> with not allocating the rmaps, KVM must also be sure to skip operations
> which iterate over the rmaps. If the TDP MMU is in use and we have not
> allocated a shadow root, these operations would essentially be op-ops
> anyway. Skipping the rmap operations has a secondary benefit of avoiding
> acquiring the MMU lock in write mode in many cases, substantially
> reducing MMU lock contention.
> 
> This series was tested on an Intel Skylake machine. With the TDP MMU off
> and on, this introduced no new failures on kvm-unit-tests or KVM selftests.
> 
> Changelog:
> v2:
> 	Incorporated feedback from Paolo and Sean
> 	Replaced the memslot_assignment_lock with slots_arch_lock, which
> 	has a larger critical section.
> 
> v3:
> 	Removed shadow_mmu_active as suggested by Sean
> 	Removed everything except adding a return value to
> 	kvm_mmu_init_tdp_mmu from patch 1 of v2
> 	Added RCU protection and better memory ordering for installing the
> 	memslot rmaps as suggested by Paolo
> 	Reordered most of the patches
> 
> v4:
> 	Renamed functions to allocate and free memslots based on feedback
> 	from David.
> 	Eliminated the goto in memslot_rmap_alloc, as David suggested.
> 	Eliminated kvm_memslots_have_rmaps and updated comments on uses of
> 	memslots_have_rmaps. Suggested by Paolo.
> 	Changed the description on patch 7 to one Paolo suggested.
> 	Collected Reviewed-by tags from David.
> 	Dropped the patch to add RCU notations to rmap accesses.
> 
> v5:
> 	Responding to comments from Sean.
> 	Improved comments
> 	Swapped args to kvm_copy_memslots to match memcpy
> 	Fixed some line wrap and declaration style issues
> 	No longer check if memslots have rmaps before operations which
> 	iterate through active_mmu_pages
> 	Re-added the kvm_memslots_have_rmaps helper
> 	Fixed a couple missing unlocks for the slots_arch_lock

Queued (with minor conflicts), thanks!

Paolo