Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] xen/pcpu: Use DEVICE_ATTR_RW macro
To:     YueHaibing <yuehaibing@huawei.com>, jgross@suse.com,
        sstabellini@kernel.org
Cc:     xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <20210523070214.34948-1-yuehaibing@huawei.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <c27b37e3-7d4b-1ed1-2b8c-1fbde6e30c3b@oracle.com>
Date:   Mon, 24 May 2021 08:48:53 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.10.2
In-Reply-To: <20210523070214.34948-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.74.98.132] (160.34.88.132) by SA9PR13CA0037.namprd13.prod.outlook.com (2603:10b6:806:22::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.12 via Frontend Transport; Mon, 24 May 2021 12:48:56 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c420616f-ea22-46af-88da-08d91eb24b7a
X-MS-TrafficTypeDiagnostic: CH2PR10MB4133:
X-Microsoft-Antispam-PRVS: <CH2PR10MB41331DBFFA0916826EB820C58A269@CH2PR10MB4133.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:962;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 2ZIizDPRSbtEVrx5faFrCXQEqEnpQWNtevF27hiXkZYtVQySLskGcekVUzIb+SFT7hjVaSW7BeyK6kAldvqKKVUYdmGVzbVu4nbSNel82QbYlEhheii3S1/Ja/pi+uA0nwX30DV4ilQgy9qLFwCF5yEc9rILxFZR7RldOfdCVKG0t2VN05CsXcEjo7oxGD6RWLoalfp+dhdOawMHxC7Q/awoKgTg5YcdrLmPHru25K4ovVmxGv1RPx7lqX1+/1NMH4R1sBHMuq/HvD4pDHhJ8L85Hs/h9cJ+tEA60Q2CI+2icNJ7z2Qj2hrccWQborQwVf7PldqKHzRiB1+3PCR7SJBplHvx9R5tx4/CPA7Hy+fEaQ5OV3Ub7jKdiYTT2qcVTf9Vj0S25NeSCpZo8X5PWgkpluU3I5bnHSz8pTg0+u0WmT+sZVvX1oCAGwzDhw4Ecx1Cxzhlk3HF5E+s9TBXBlOc/qA54VTnY82SNytCBkqyfuaTU3i5SLe3wNZav55wmDSHuaF+weqd23ROFutPCtbhBOkRzcvZ/CZlBa5+sb5waqcmsJqJowA3Lrh0i6+qM3T6xsgmNmrzL64WrTgfiSHUcSKW50ob1/dahMhzE6+vLqFKeN3RzPVQFb1KgBIZeIMssratclEMCKkCWd4KxKSYeJY5v+/o579D7//d2Ktst9BQ+U+NQyXEaVchxaaD
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH0PR10MB5020.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(396003)(136003)(39860400002)(346002)(376002)(44832011)(86362001)(8676002)(2616005)(478600001)(31686004)(31696002)(66476007)(66556008)(66946007)(956004)(316002)(186003)(26005)(53546011)(16526019)(8936002)(5660300002)(6666004)(36756003)(6486002)(4326008)(2906002)(38100700002)(16576012)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?QUk4Mit6a3QyeFQ0clh3RlBXcGI1c0QzRVpRbUh2QitEdU5HTnd4Rndqdks0?=
 =?utf-8?B?ZElRR0szVU16ZC9UcDB0Z1ZnaWNOQnNPS1U0em9zcWRJN1paeDR0TXJDV2ht?=
 =?utf-8?B?RFphdVVMb2pmYmRtTUZMaHNvanJWMlgyVjIrRStwc0YrenZrREJNbWVtODhQ?=
 =?utf-8?B?VlQwaHRKRGhkcGlOWHMzVWZvNm1PSmtvQ3FKRE9pSVNJNG40TExwTU1hNy84?=
 =?utf-8?B?VkxtVUZOV2xybnFPc1MrMDR5bFBpL2pIUm4rc2NaZTZxNFZaUGszWk8waUs2?=
 =?utf-8?B?YnlmeHBXWjRXQlJZNXJ2cWlmTUtwMlJGblZHRVd6VTVuQkdJT2duMktJQ2Jq?=
 =?utf-8?B?UGhiaVR6VFlqNVA4VDJ2WlJEK3NGUDFFVWRJYlM2QW1rYkZvS3h6TVRRemtk?=
 =?utf-8?B?VlNSNnR5UVNBZWw2M25MK2F1cGJreGJzOURzNTRDNkxPdEtXMWE5Z2hOMFlD?=
 =?utf-8?B?WThXd2lnNTNwYVlIZXNYbVNib293a2pXRWNIUzhSa25FajhlalVhdFB6ZUlL?=
 =?utf-8?B?OEo2STlvV09ZVTNSNmtxSnNPd29YUm5jaFFGYjc0eHF1dE9FemRyd1NkRElr?=
 =?utf-8?B?cDFic2hIclpPeEtxZnlmbWUyZnFuZGdQcjFwRkM2K3FhZHNQQW5GY2pmajhV?=
 =?utf-8?B?Rzc2RTlBaHRCdWNMZ1ZyaGwreituZ0IwMUtySWtzNFB5YWhUUEhvQzEzc3Yz?=
 =?utf-8?B?Wk5Da0l2azBtVFBTSkJrZlBHa1Q5c3BYUG9vUzFheGVFQ1lUUDdESkhKV3lI?=
 =?utf-8?B?ai9JR0dhSElLeFE3aHdRd0xrekxMRERIR2Z6SUlKV1Z4a3U3RHlIVGlaQ29v?=
 =?utf-8?B?UlhvUEpiZlJHeVpabkRaUXJwYjVGWnZlNWxMejJvYlVSYUJtem1CUDh4Nmhl?=
 =?utf-8?B?VFpSeGZENG9lV09nU0pQWW5JUkV2SS9vcitpMVVHZ2pCcDhEK1MvNjBwdUg5?=
 =?utf-8?B?Wk5RYUNPMktiV0xKaEU1NVllRlN6N3FDMXRwZ1RINTBPbHNLdk5aRTJRMHNp?=
 =?utf-8?B?WE5iSHA0VE8xVEdWUXFDMXNsclBzbWlBbG5MZjg4V2w2NG5KTmhhdnlOMCsv?=
 =?utf-8?B?RnlLVVQwQndtdndzbHJ4NHVPRmNsUVdmNDQ3Y1RkM2RxdWZReDllRjgwUU1B?=
 =?utf-8?B?cVh1RzErcGY0MzFKTzNhd2Y0cFJmbGFGcnVFRGltQXVPa0lXM2V1L2NqWFVr?=
 =?utf-8?B?UVVmbjBvSWxWNVcvVnNqZCt2bS9qc1VGRWR0V1ZRa2FrRjRCa1pNZzd0K3BI?=
 =?utf-8?B?SnJqMTl1OHk0TEl6T3dBU1hhK250VnhlMm9DMHgrZTdHTllCOXBiVzR6SEtF?=
 =?utf-8?B?aEJCUFh1Rkd3WXJ6YzlOREk2Rzk3SEFWVFNGRVVacWpCUmZvQXlDMUJuaWk2?=
 =?utf-8?B?K25ISWtROW9UTVB3dVZMNTB3UjdEaTBMTjlMekR3dkI3ZzdaWlgxYkF1Ymg1?=
 =?utf-8?B?MlorVDVyZDFvdjcxZy9FdzVldlcrYS8yRDZXVDhYZFpOOUQ0cFFsS3MzemNt?=
 =?utf-8?B?MmcrUHNOQy9QZkR2czhGSlBkNHZGYVVjUFM0aUhjQnJOdU95Zk5HTTljMndj?=
 =?utf-8?B?b0lLN2t6UW05Y1NJS1cvSzUzYU0wRWNlSzk2UnphVFJVV1hyMmV1TEhIZjVa?=
 =?utf-8?B?dDlMRHY1QXJFdjJqQ0Q3TlcyV1NWOU14ZWEyYUt2NXgweVh5ODBZdDE0N1I5?=
 =?utf-8?B?d3FDRkxSM0JhVG5IUEZFcEtxRlMxNDJ1aktCOXUxak1RWEpGb0tUa3NLek1x?=
 =?utf-8?Q?Zr2O/JjxcrI8YRuU84zsVnZlvv0x1T7Yd7UeugY?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c420616f-ea22-46af-88da-08d91eb24b7a
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5020.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2021 12:48:57.2195
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LlwFnVuVrZFwTdXUMvWktk1XyM8NWD6Bi8hGDIhHdDYFpo9e5IE9CGnFv+O98H1TWgjsR5HPhN+tSeRU9M9LKupaH/Iafj22KKZaWhRNyJs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4133
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9993 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0
 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2105240083
X-Proofpoint-ORIG-GUID: 9N6i1w6HVHdfrVWS1x4Olg2NYGIUA5Gc
X-Proofpoint-GUID: 9N6i1w6HVHdfrVWS1x4Olg2NYGIUA5Gc
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9993 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxscore=0
 malwarescore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0
 adultscore=0 phishscore=0 priorityscore=1501 clxscore=1011 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2105240083
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/23/21 3:02 AM, YueHaibing wrote:
> Use DEVICE_ATTR_RW helper instead of plain DEVICE_ATTR,
> which makes the code a bit shorter and easier to read.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>


Do you think you can also make similar change in drivers/xen/xen-balloon.c and drivers/xen/xenbus/xenbus_probe.c?


Thanks.

-boris