Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3618123pxj; Mon, 24 May 2021 10:41:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwM2JefIU0Yk5E44Awov+W/1LQ8nrKSEND0MiG2j99FjZbjXXNBI9546vv7yGSfXB+zykQM X-Received: by 2002:a5e:9e4a:: with SMTP id j10mr16689084ioq.52.1621878061009; Mon, 24 May 2021 10:41:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621878061; cv=none; d=google.com; s=arc-20160816; b=eKR5ZzIMGHva6FPKhWyvki4aHYLCKH+byxwJbVKZkHQsGwDfOjB0BP+Ghtt09zCsH4 NXXEfWdtXZWgqXUYvKMzs9rK7W0v+rypLoF9/BWxkizQyoweJhYihSBaF7PJouoi5bvN v/wENJgkt9XmvrkjB/DG0mOWrTJKLHowH7DlIqBnz3PX3s+Ewz1wtrn1+4sW991VU7/7 VoShxYvfFZlbRkSxtdsF7sp1Je1XpnhTU7ZThXTWAUJEHeuswrCx+j0tSAyzi9DNEPcG P2Li3IZ95axrZ59+nsNLpqDJ9iI80PK0idQ4uhUaWbqEIzWcQcEQpx5Y3CyOcxKTTAWR hN7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sTMdfl7490EUvFpi8+cM20l+2QkFa8OjDn3LY3LnB8g=; b=GblErXzBMC+aGDPuSm/fdUMBcB6482f+E8guodtNAPfQs3rRTSDDiofuzs5xCRl3Q2 rHtfYBMu/+aAURrBpRjdMRPMQs2QxexIlgS5AQi48BSvAaq7OGUgy0fSJZAwyDoJql2W 9nVqMZFdV3SHHGglUjYt0TRSLC85No0RoGFLT8PXCMuqS7Gy+l6nbI/nvbMYfVA39VOB JOmTHkGNrnJlHUqCtsrzOUDdDVFFqkpVxa3S5wJZdcG8h+Ux02xUqIJn1dGuarVNUtWx W6Fas+mgwrotZAO12kWoAyp+EGI2H/4Nc68qmnKQzoMO5sBkZbX6IfHu0l75ifBUcJab 2/Qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="n8fH/VMb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s6si12871324ilj.161.2021.05.24.10.40.47; Mon, 24 May 2021 10:41:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="n8fH/VMb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233551AbhEXRlg (ORCPT + 99 others); Mon, 24 May 2021 13:41:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233509AbhEXRlf (ORCPT ); Mon, 24 May 2021 13:41:35 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20EDAC061574 for ; Mon, 24 May 2021 10:40:06 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so11562671pjv.1 for ; Mon, 24 May 2021 10:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sTMdfl7490EUvFpi8+cM20l+2QkFa8OjDn3LY3LnB8g=; b=n8fH/VMbgfd6cRp/TQjx3U196IeCN0qxIEAi6w1Ejs/HL3HtQn8A4RC+PkbAaJ7YXx v2DYyU6k6hdak4BbLALW0lx0Tpf3yWbHUeoCnJhdtcnFVicNtqGCbErlV0W80aibgVLo qcq7Kx3+j8rl6PWfSyH9cYgLp4BLtao7OZ96GjGyG3Xwuh4IygxcgZk4TJHUOM3tMe72 jrlBH5ugkQvAvRSHx4zN54AWLITw8/UCnoTZFv+pwuBnPrX5Q+/XgabEUZf6Mw+mibNE nOe3pHgoUHfkkH5OAClqOiO0MZpeQtS4tQ/Dy7ZuIpCZkZRp/KzZPuEOqtc+NVlQ6lbr p1wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sTMdfl7490EUvFpi8+cM20l+2QkFa8OjDn3LY3LnB8g=; b=TJa9HhcQzGqgjw7ZGYIPTmdqUxlyOsFLsXScGCfuZC0sYiMf2c43S45W2Lp3rpgKMj Ni5woOMu3e5oXABmbyzGFGTFedW/YfYQyH3qXT34QdO/ExARst1cnuaFlHJEJ/STERGl YWC+bEg8ox3VMPS2tAVzoz6YlSmDpK+sT19zjv7NvnDv4DxdeCq0HG9x3N0XoU6UeT+5 iwHLquBaaOKYyovIFWo7GFEztKxOeC5qJnWP7YoOfq4wpwMXRDWDp48vg0wFcW1lAdBy 2bhUkU4PtcXZFaHoA0aCXyRsGgA24ea62fowpgpzsIs9TGZQcH91KxsuAs1KDfZvUM7m u0zw== X-Gm-Message-State: AOAM533PmOHSwuaqzxsW5pFZc3dFSr0mo6YxasEpQ1gIWw7zIxC/4pN6 qrq/ez6COsltSi7O233//xU= X-Received: by 2002:a17:90a:f518:: with SMTP id cs24mr292344pjb.182.1621878005779; Mon, 24 May 2021 10:40:05 -0700 (PDT) Received: from hyeyoo ([183.99.11.150]) by smtp.gmail.com with ESMTPSA id n28sm5193454pfq.139.2021.05.24.10.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 May 2021 10:40:05 -0700 (PDT) Date: Tue, 25 May 2021 02:39:59 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Jaroslav Kysela , Takashi Iwai , Greg Kroah-Hartman , Oliver Neukum , Vasily Khoruzhick Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: line6: Improve poor error handling in line6_init_cap_control Message-ID: <20210524173959.GA116743@hyeyoo> References: <20210524173644.GA116662@hyeyoo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210524173644.GA116662@hyeyoo> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org added an error handling code. It builds well, but I don't have the device. So please review it (and test if you have one) if you think I can improve something, please tell me. I'll send v2. Thanks, Hyeonggon