Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: VikIWC0O64EJEU2JonyeakULWsI3Lfmd9u09y13hKrh9sIbadXz9IqQE2Jm0si2W5uG1abIBsm
 FVHZPfoXHv9A==
IronPort-SDR: OlsffDRvw6Ck3jliqwWLI7pWWUS5/npJ8ygggjY68fmIX9s4ZMbLsUimSKdr2EGbtrN0r0dRIR
 zyiRPgKH5g0w==
Subject: Re: [PATCH] ASoC: Intel: boards: Select SND_SOC_HDAC_HDMI for
 Soundwire machine driver
To:     Richard Fitzgerald <rf@opensource.cirrus.com>, broonie@kernel.org,
        cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com,
        yang.jie@linux.intel.com,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc:     alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        patches@opensource.cirrus.com
References: <20210520163324.19046-1-rf@opensource.cirrus.com>
From:   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Message-ID: <9ed54875-fe77-f70f-9085-0f3b4c9d576e@linux.intel.com>
Date:   Mon, 24 May 2021 11:32:06 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210520163324.19046-1-rf@opensource.cirrus.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/20/21 11:33 AM, Richard Fitzgerald wrote:
> Add select of SND_SOC_HDAC_HDMI for SND_SOC_INTEL_SOUNDWIRE_SOF_MACH.
> Without this the build results in missing references to
> hdac_hdmi_jack_port_init and hdac_hdmi_jack_init.

Kai, can you comment on this one? There is nothing specific to HDMI in 
this driver.

all the machine driver entries are now protected with a
	depends on SND_HDA_CODEC_HDMI && SND_SOC_SOF_HDA_AUDIO_CODEC

but some entries have the select SND_SOC_HDAC_HDMI, others don't.

Something's inconsistent here, it's not limited to SoundWire I am afraid


> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> ---
>   sound/soc/intel/boards/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
> index eef5f4ac87c5..6a1639b14b67 100644
> --- a/sound/soc/intel/boards/Kconfig
> +++ b/sound/soc/intel/boards/Kconfig
> @@ -601,6 +601,7 @@ config SND_SOC_INTEL_SOUNDWIRE_SOF_MACH
>   	select SND_SOC_DMIC
>   	select SND_SOC_INTEL_HDA_DSP_COMMON
>   	select SND_SOC_INTEL_SOF_MAXIM_COMMON
> +	select SND_SOC_HDAC_HDMI
>   	help
>   	  Add support for Intel SoundWire-based platforms connected to
>   	  MAX98373, RT700, RT711, RT1308 and RT715
>