Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3652007pxj; Mon, 24 May 2021 11:31:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXAgzWEv02bg+d3UvqKtMXedTlA56uS6NWvASfT/WoBDAa6WbA2ruWzDlt0GiNtw63Q/He X-Received: by 2002:a05:6e02:118b:: with SMTP id y11mr19297216ili.241.1621881073409; Mon, 24 May 2021 11:31:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621881073; cv=none; d=google.com; s=arc-20160816; b=d+4nWRgaHf4E3xR60TR4StEC/ZGUq8XHR1KAP+3Px0xxTxvcdAdHVvzVh8i/hPG+Va 2slM3jwfCf8+VePIu/N8Sngqujx4zvx1/B4UgCTed85UY67DV4GUVEHhyhYt9EBiIMji o+LuggX9klp0M91qH39fq+aecgVMRTpH3vrx3PVxyry1g3gPkz6BjlPZc3QVqmYxz+hg rOzjJRyS1/snMpVjkWfCnR/PQMs5HmgTeb3mNiO5dFF7rIAq0+GVOheGb4KYUgMrTXKP 9+j7XGndKBcnyE/Jp/Ore5jKThDKJZPv63llTlgLVoqOYN9GQaD+67yBqRgjzBnj9XOe UihA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=6l8tpFWcrkE3f47XXyYCtf/V8qcfC/xS80HXRuYITKo=; b=tsmRYnheaSLgQKnv9f7bL00x6uf9iCh7b5VtuURJfKuZNoXYfsbGtHBQmTZw1Bvkbs pRmTtNeY9mIX1Y+WhuaXRvqpglcaDybrY59XS6ATjfHeFM6H44g61LHkDRU0nbSIN5im yCpWw3FXUqBkUIqetRxB3R96+EB1UGrpMJmsuwrAnHr/A9AO1fdbBNdo00YzjYkqiFXG Og/1bLGTA/tS+c52psLlrjbqpNJc9JGjGqsXWNA97xRdVaPpbkIL0BZ+iRm9z4rKMGrA bmBOF4djcKVjwxHrNYQ3OPFVJJ7pMEVfYYwCk5KPldoXxlU/977XRiThRj6sSCLMvIEX liNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j18si14519442jaq.76.2021.05.24.11.30.59; Mon, 24 May 2021 11:31:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233842AbhEXSae (ORCPT + 99 others); Mon, 24 May 2021 14:30:34 -0400 Received: from mga02.intel.com ([134.134.136.20]:17184 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232709AbhEXSae (ORCPT ); Mon, 24 May 2021 14:30:34 -0400 IronPort-SDR: 8iTV/WKsfwR/slquz1ujVPf28lm66iLCd2XjqgCErxLtMPq3Bs93gQDNkWZAHrZmEqZzD0GEFq mp3B0kKU4oDw== X-IronPort-AV: E=McAfee;i="6200,9189,9993"; a="189124113" X-IronPort-AV: E=Sophos;i="5.82,325,1613462400"; d="scan'208";a="189124113" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2021 11:29:04 -0700 IronPort-SDR: nLEBItXc5a1Wqtr/4fUeh/Cc2rqqcp1gF/4dHbyVIT1MqhHUVqPtZFRZkQ3CS1OXM9xKc0KboB Oc4McVEnHo7g== X-IronPort-AV: E=Sophos;i="5.82,325,1613462400"; d="scan'208";a="478737519" Received: from caknoll-mobl.amr.corp.intel.com (HELO [10.209.100.8]) ([10.209.100.8]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2021 11:29:03 -0700 Subject: Re: [PATCH v5 25/28] x86/fpu/xstate: Skip writing zeros to signal frame for dynamic user states if in INIT-state To: Len Brown , Andy Lutomirski Cc: "Chang S. Bae" , Borislav Petkov , Thomas Gleixner , Ingo Molnar , X86 ML , "Brown, Len" , "Liu, Jing2" , "Ravi V. Shankar" , Linux Kernel Mailing List References: <20210523193259.26200-1-chang.seok.bae@intel.com> <20210523193259.26200-26-chang.seok.bae@intel.com> <6197fd94-76a9-a391-f290-7001a71add7f@kernel.org> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <9963bd19-5d3b-906e-e42f-1aeb266d6374@intel.com> Date: Mon, 24 May 2021 11:29:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/24/21 11:15 AM, Len Brown wrote: > On Sun, May 23, 2021 at 11:28 PM Andy Lutomirski wrote: >> But what happens if we don't have the XGETBV1 feature? Are we making >> AMX support depend on XGETBV1? > > Yes, AMX systems always have XGETBV. XGETBV1 support is actually separate from the XGETBV instruction itself. XGETBV1 even has its own CPUID bit. This means that a silly hypervisor or lazy future hardware implementation could decide to enumerate support for AMX and neglect XGETBV1. But, it's perfectly fine to have our AMX support depend on XGETBV1. We even have a little dependency checker table which will clear the AMX feature in the presence of one of those silly hypervisors.