Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210515075257.7918-1-aardelean@deviqon.com>
In-Reply-To: <20210515075257.7918-1-aardelean@deviqon.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Mon, 24 May 2021 21:00:20 +0200
Message-ID: <CAMpxmJWBi=R21pK0-g4j8bOfh7Hy4tmFrcKY+X23+c2f2CiKjw@mail.gmail.com>
Subject: Re: [PATCH] gpio: gpio-tps65912: remove platform_set_drvdata() +
 cleanup probe
To:     Alexandru Ardelean <aardelean@deviqon.com>
Cc:     linux-gpio <linux-gpio@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, May 15, 2021 at 9:53 AM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
>  drivers/gpio/gpio-tps65912.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tps65912.c b/drivers/gpio/gpio-tps65912.c
> index 510d9ed9fd2a..fab771cb6a87 100644
> --- a/drivers/gpio/gpio-tps65912.c
> +++ b/drivers/gpio/gpio-tps65912.c
> @@ -99,7 +99,6 @@ static int tps65912_gpio_probe(struct platform_device *pdev)
>  {
>         struct tps65912 *tps = dev_get_drvdata(pdev->dev.parent);
>         struct tps65912_gpio *gpio;
> -       int ret;
>
>         gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);
>         if (!gpio)
> @@ -109,16 +108,7 @@ static int tps65912_gpio_probe(struct platform_device *pdev)
>         gpio->gpio_chip = template_chip;
>         gpio->gpio_chip.parent = tps->dev;
>
> -       ret = devm_gpiochip_add_data(&pdev->dev, &gpio->gpio_chip,
> -                                    gpio);
> -       if (ret < 0) {
> -               dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
> -               return ret;
> -       }
> -
> -       platform_set_drvdata(pdev, gpio);
> -
> -       return 0;
> +       return devm_gpiochip_add_data(&pdev->dev, &gpio->gpio_chip, gpio);
>  }
>
>  static const struct platform_device_id tps65912_gpio_id_table[] = {
> --
> 2.31.1
>

Applied, thanks!

Bart