Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3800749pxj; Mon, 24 May 2021 15:27:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJylf8r/yBwUWqqXtp03NPaduNoNj1Ye547F7w9xyG4OZmCdAHS8nq5RnqPIUat4Kh4Y1JOg X-Received: by 2002:a17:906:1c46:: with SMTP id l6mr25723901ejg.328.1621895225773; Mon, 24 May 2021 15:27:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621895225; cv=none; d=google.com; s=arc-20160816; b=YcMgnBLmp7L7ImhCztqmS+jr87I64KsVVcVCGf41qj3igv7fNL+HjSc7FIDEuc7tFZ xTMxDDKR7xDSquTZdnND6DUwU8+1hZmq0F4zHvNpOhjVir+Xi1VA3S7u/pYDzLQENMJu xzMjE/uh3OEIETEh2ErrK52OUXUWxIeXrq8q+v6Ca3w4zFNSXB0stGHrMKLus6JJCtRD Qk6XHgHTOmXSptFcaYk70XsSAblAF1OVQusM/bL7MJlp4Lqy0igvpjkqSkvYh3Qpz5vX VTP3d7MUBZxdocF2PR4RDXKXDVWxxFyLEo5ZqL6gLEr+VN4q4mN9qgp97/XkTXf/jETr VLRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=aMbtVZ04yEp9CiJivQZnjUMM6QcCJBMfyrWrbkkG9ec=; b=xmiF3/7RdqK/w847Tjy5hgyHLhKiCaJ5NzyOd8rCyGrHz6k6VB6NyMys+vwKA0Xn5N Rqo4aqeDD7eP0f25HK178IdfqQxoBIEQQWnFftq8Q25FNW1HkdH/8oqT9anY8OWQW6np XpxNHpHP6g3fheXGcCN00Nv5Wh7I43NQ5cIrX5UVYzwknXW8TwBCH/L+kulI5LHBNQvM CiGehjMeW7MViaZxs7ZnPyvp00OgqR34/cFe4hmiKO7UcpASavSQmG6aTeya2UOSpRjh Grko1v8IZ4Q5XDmaNZp27DpiEbwk4BICc25qUCDhAgVJhYoyDHPKl4r3gVwvLPAwyBm+ eD3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id se5si13463150ejb.554.2021.05.24.15.26.42; Mon, 24 May 2021 15:27:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbhEXW1N (ORCPT + 99 others); Mon, 24 May 2021 18:27:13 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:46851 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbhEXW1L (ORCPT ); Mon, 24 May 2021 18:27:11 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id BDC4C240003; Mon, 24 May 2021 22:25:39 +0000 (UTC) From: Alexandre Belloni To: Lee Jones , Alessandro Zummo , Arnd Bergmann , Matti Vaittinen Cc: Alexandre Belloni , Claudius Heine , Linus Walleij , linux-rtc@vger.kernel.org, Guenter Roeck , linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH] [v2] rtc: bd70528: fix BD71815 watchdog dependency Date: Tue, 25 May 2021 00:25:39 +0200 Message-Id: <162189513064.208942.8503261764736710854.b4-ty@bootlin.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210422151545.2403356-1-arnd@kernel.org> References: <20210422151545.2403356-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Apr 2021 17:15:21 +0200, Arnd Bergmann wrote: > The added Kconfig dependency is slightly incorrect, which can > lead to a link failure when the watchdog is a loadable module: > > arm-linux-gnueabi-ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_rtc_based_timers': > rtc-bd70528.c:(.text+0x6cc): undefined reference to `bd70528_wdt_set' > arm-linux-gnueabi-ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_time': > rtc-bd70528.c:(.text+0xaa0): undefined reference to `bd70528_wdt_lock' > arm-linux-gnueabi-ld: rtc-bd70528.c:(.text+0xab8): undefined reference to `bd70528_wdt_unlock' > arm-linux-gnueabi-ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_alm_enable': > rtc-bd70528.c:(.text+0xfc0): undefined reference to `bd70528_wdt_lock' > arm-linux-gnueabi-ld: rtc-bd70528.c:(.text+0x1030): undefined reference to `bd70528_wdt_unlock' > > [...] Applied, thanks! [1/1] rtc: bd70528: fix BD71815 watchdog dependency commit: b0ddc5b170058a9ed3c9f031501d735a4eb8ee89 Best regards, -- Alexandre Belloni