Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] lib/math/rational.c: Fix divide by zero
To:     Daniel Latypov <dlatypov@google.com>,
        Andy Shevchenko <andriy.shevchenko@intel.com>
Cc:     Trent Piepho <tpiepho@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        andy@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
        oskar@scara.com, Yiyuan Guo <yguoaz@gmail.com>
References: <20210523001806.3927609-1-tpiepho@gmail.com>
 <YKuFPeH0sIFqrBt6@smile.fi.intel.com>
 <CAGS_qxoKTyNBxoezkEVVrACGsFuzJwteepVpDzp+4KH+CgbMsw@mail.gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <b5511f68-814b-1f8c-08d2-a7dbddce4e8d@infradead.org>
Date:   Mon, 24 May 2021 15:04:21 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <CAGS_qxoKTyNBxoezkEVVrACGsFuzJwteepVpDzp+4KH+CgbMsw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/24/21 9:55 AM, Daniel Latypov wrote:
> diff --git a/lib/math/Kconfig b/lib/math/Kconfig
> index f19bc9734fa7..20460b567493 100644
> --- a/lib/math/Kconfig
> +++ b/lib/math/Kconfig
> @@ -15,3 +15,14 @@ config PRIME_NUMBERS
> 
>  config RATIONAL
>         bool
> +
> +config RATIONAL_KUNIT_TEST
> +       tristate "KUnit test for rational number support" if !KUNIT_ALL_TESTS
> +       # depends on KUNIT && RATIONAL  # this is how it should work, but
> +       depends on KUNIT
> +       select RATIONAL # I don't grok kconfig enough to know why this

Only to set the symbol CONFIG_RATIONAL.
Then when 'make' descends into the lib/math/ subdir and looks at its Makefile,
it will decide to build the binary rational.o.

obj-$(CONFIG_RATIONAL)		+= rational.o


> is necessary
> +       default KUNIT_ALL_TESTS
> +       help
> +               This builds unit tests for the rational number support.
> +
> +               If unsure, say N.


-- 
~Randy