Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 May 2021 09:27:49 +0800
From:   Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To:     Marco Elver <elver@google.com>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        kasan-dev <kasan-dev@googlegroups.com>,
        Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH 1/2] kfence: allow providing __kfence_pool in arch
 specific way
Message-ID: <20210525092749.3ceac5ad@xhacker.debian>
In-Reply-To: <CANpmjNOVikz=u90-xQKzWGxbH_ov5R_EkuG6ZLqVAkjkgw8Z2Q@mail.gmail.com>
References: <20210524172433.015b3b6b@xhacker.debian>
        <20210524172529.3d23c3e7@xhacker.debian>
        <CANpmjNOVikz=u90-xQKzWGxbH_ov5R_EkuG6ZLqVAkjkgw8Z2Q@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from xhacker.debian (192.147.44.204) by BYAPR11CA0055.namprd11.prod.outlook.com (2603:10b6:a03:80::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23 via Frontend Transport; Tue, 25 May 2021 01:28:00 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5e2d6f26-0532-4395-8717-08d91f1c577f
X-MS-TrafficTypeDiagnostic: BN8PR03MB4690:
X-Microsoft-Antispam-PRVS: <BN8PR03MB469080361A7DDEAF90E8D5B2ED259@BN8PR03MB4690.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: dvMenRLpvjweu9NQBIVtMsl93iSJEI9w2uY+sn4DltbfqqpVuyDrWEOAsDDK9n04mJY5cSvOD22vDwSyVww5WvMxHyE6k0HM6Go5BdZH+VUcWEAdLL++Bke+4tz+uWal5ZBYHi4fvYwasv/hKn7e3h8oVe0Q19lWuo/7nJsylOM8b/eW5RN7DWncheS+6V1DUBweJcnZQQEfwOzvN+I8euZroO+lOebkA8Y6YD7dbYfJfd869KnnoXlCQxeNtB1y0MfY22luK7V9aw2K7gZvDPcn3NOGf3jkFuK7QatfUwffSscRysUE9NyrvFUsI62Kq7XSEEC/IlR/SLxDe/YGifpTRcjOOnxKktMDcCXKuufIzUCUn8dLzTr74uynyGMOHFpv0DohrEEN3auFMxeHp+BAbr543kM4colMDBx95nMKHTh0mWFPn0VMTQSQ+gsdqmZ70p47IP6XHiErHqD1xSBunkcMWZG3iDr841STxYgNiLYZIaf/6QWhSH79hEEwT/1TyN37Eja/Tg6T4Yqswns8TFn8nUYTjIBiq1jX9UmOK1j4q9iixqg0gVXTkELqBl2Q1fYe1TtWKn6z76rqUUBVpHgZ2GNI1I7UzqrIIRRK45wSa7sOA657rjzWDybGbr4tZSf42x3/AlV3cJ3G2rgyeakBMtAB3ognXne9xk8=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR03MB6058.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(39850400004)(366004)(376002)(136003)(2906002)(38100700002)(5660300002)(1076003)(6916009)(9686003)(38350700002)(478600001)(86362001)(956004)(7416002)(6666004)(316002)(54906003)(8676002)(26005)(83380400001)(66556008)(6506007)(7696005)(4326008)(186003)(55016002)(16526019)(8936002)(66476007)(66946007)(52116002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?4CGw4K5CBWjv+igeDThnZmmhu4ylDASbWaEn5NSfzhiSSbD6KL0dJcyt3e+C?=
 =?us-ascii?Q?hF0D0CeTfudkYpak9xu9AfRomd+9rmQIwhq+aobkg/+CvjeugBmKkWV09PYv?=
 =?us-ascii?Q?EUGtyjOByhPyDTltUmrJsTJrF4K8mWKhpneaUT83OOt+N6WqWiJTspkOiQOb?=
 =?us-ascii?Q?EjSX8Ufftt1DQC/UUhFg0+/rW9nFs9/Oj9CxBLj00nBeK5kq0UXHegy70D5P?=
 =?us-ascii?Q?NZCdOSsd8UV/D+3x2SvayzW0HU3oItccPdzBJjr2f1zwg84r7R3BO0h9/6wy?=
 =?us-ascii?Q?MZrh+Qcqn0LKK7BaKx6IpSjKV/6Xu24Fxwt8fwWC3AOcFR+HoSYqJCwXCWnQ?=
 =?us-ascii?Q?8G+dxBwPi3a6Y3S7i5ZfEg74E3mRLdVN7hoQgXKrZD9poY5+7NfL44hAGved?=
 =?us-ascii?Q?CnPxY5TTPeSzV2uxllWV4FW9b2rjJ72/NKqhyzD5jEjtj1nxL5AF+dDoBCC+?=
 =?us-ascii?Q?Zys6GXjiykv3aqDjJUZHt+DZRFarT8BoiEXxVQkLKNsPRsDlvwa9bk1x6qDG?=
 =?us-ascii?Q?2IsfhJCD6jYEfIO+xxRrlxzPcFRrBIyxgMCzZPee0FxgYNNf1z8hGrVs96KH?=
 =?us-ascii?Q?v5L6SnsrgHFDUo5XP9u1eRPmBMtI4S8hg3V5cnEHV1TZonHXZ0SIpFVjJMz0?=
 =?us-ascii?Q?pnpwufZfYkdsswRzCqZp8cqd7vy/+6bjTqTlpncRGqcdKvxsiv/NuZ1tZ8fV?=
 =?us-ascii?Q?v8jThqTDCIexiXLvcYGrR6wHLUfZS7WEveHv7M442ycjszuhdlWyUKiukT4M?=
 =?us-ascii?Q?nSFKOPgjsiC+wxUagZzDxrIU9orz/uZx4QbTZj7/HRTw2ur2Ng/8l8mdH6uR?=
 =?us-ascii?Q?i0Cl5n7o6WpGe+fWaCb5hDbRg4zmWIvOOigIogPUhCLy7/EEhDS+EqO2Wjm0?=
 =?us-ascii?Q?piQuZ6c9ko0Mp6DlkqJ1OdVxokPm6Y4EibLyL+BHUGJBXJyW1keb/zJEVnQO?=
 =?us-ascii?Q?DoQqgjf3POuSFE2zs8W9ZYo1MJzAVbrkHi6hLXeDXAW9uRH857LHRpwFT+Vm?=
 =?us-ascii?Q?N3RPyECJdLIo93vv4GmtaktMPSw3764ETSEM42RG1tjyWn3rRrj6OQ3mi+II?=
 =?us-ascii?Q?/DaoTJ//AEf+AcoXmHKZF+hSLE+aPOhxX7/rQp6RZzctObn+3rWhjcQhhLMG?=
 =?us-ascii?Q?8/PW9Btu4xtpvGMv93ocIByfE6UqOIwkFOeqmrtjn3UgEBvCl24+woZe5S4D?=
 =?us-ascii?Q?g5TChSDG/2Y1Nvl/X2c/d+kF9pQ/XqikBMpeyivhuSUAOd00e+yGItqWgISm?=
 =?us-ascii?Q?76090+n7xrTiJrZ8ghBZNUhP3DD/jMwsAFQr3CFlPIwpu78olsTJgnSHfFnL?=
 =?us-ascii?Q?QHH7mf8i8pH4w7NySotKCxsG?=
X-OriginatorOrg: synaptics.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e2d6f26-0532-4395-8717-08d91f1c577f
X-MS-Exchange-CrossTenant-AuthSource: BN9PR03MB6058.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2021 01:28:03.9098
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y3/+E/SGXChjpx2+IPUGm+kXfI01Gp2IMaOuX3raL0cjBHJ1sBzqoKHuH+tU4jSMXhStmH35MvOTVbflmYP4IA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4690
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 24 May 2021 12:36:34 +0200
Marco Elver <elver@google.com> wrote:

> 
> 
> On Mon, 24 May 2021 at 11:26, Jisheng Zhang <Jisheng.Zhang@synaptics.com> wrote:
> > Some architectures may want to allocate the __kfence_pool differently
> > for example, allocate the __kfence_pool earlier before paging_init().
> > We also delay the memset() to kfence_init_pool().
> >
> > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> > ---
> >  mm/kfence/core.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/mm/kfence/core.c b/mm/kfence/core.c
> > index e18fbbd5d9b4..65f0210edb65 100644
> > --- a/mm/kfence/core.c
> > +++ b/mm/kfence/core.c
> > @@ -430,6 +430,8 @@ static bool __init kfence_init_pool(void)
> >         if (!__kfence_pool)
> >                 return false;
> >
> > +       memset(__kfence_pool, 0, KFENCE_POOL_SIZE);
> > +  
> 
> Use memzero_explicit().
> 
> Also, for the arm64 case, is delaying the zeroing relevant? You still
> call kfence_alloc_pool() in patch 2/2, and zeroing it on
> memblock_alloc() is not wrong, correct?

memblock_alloc() returns virtual address which can't be used before paging_init()
so I delayed the memset to kfence_init_pool.

> 
> Essentially if there's not going to be any benefit to us doing the
> zeroing ourselves, I'd simply leave it as-is and keep using
> memblock_alloc(). And if there's some odd architecture that doesn't
> even want to use kfence_alloc_pool(), they could just zero the memory
> themselves. But we really should use kfence_alloc_pool(), because
> otherwise it'll just become unmaintainable if on changes to
> kfence_alloc_pool() we have to go and find other special architectures
> that don't use it and adjust them, too.
> 
> Thanks,
> -- Marco
> 
> >         if (!arch_kfence_init_pool())
> >                 goto err;
> >
> > @@ -645,10 +647,10 @@ static DECLARE_DELAYED_WORK(kfence_timer, toggle_allocation_gate);
> >
> >  void __init kfence_alloc_pool(void)
> >  {
> > -       if (!kfence_sample_interval)
> > +       if (!kfence_sample_interval || __kfence_pool)
> >                 return;
> >
> > -       __kfence_pool = memblock_alloc(KFENCE_POOL_SIZE, PAGE_SIZE);
> > +       __kfence_pool = memblock_alloc_raw(KFENCE_POOL_SIZE, PAGE_SIZE);
> >
> >         if (!__kfence_pool)
> >                 pr_err("failed to allocate pool\n");
> > --
> > 2.31.0
> >