Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4044636pxj; Mon, 24 May 2021 22:26:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxG1ZrTrXMbHtyXuzrME2O0nPvbvWuoKqOUBIbO1dK9uZOqUd4MlK2bINsGicAjNZ8h239U X-Received: by 2002:a92:c7a4:: with SMTP id f4mr1946419ilk.119.1621920369408; Mon, 24 May 2021 22:26:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621920369; cv=none; d=google.com; s=arc-20160816; b=s8bQylXSZFwLbhRtkVI91Ri5MF5Xvft42Yeq9zJ3tsmOUkvVK6EgK3U+8TeMK/V89A 1wE5kYkvoQIK/lsqnpAsDIh3FzAikRQufd0PpLnZc3Fc73dR2RGDjeXW+J9ZToTOFom7 nLUoK48LAR7+/eghdqUKv9gKOyzQZFCucGqdY0/cUPlOEreM6LSxxrWK4+1vYy2MJ5aa qZkSUF3conAvrfA7pbq9M2mzuHe5buv+Jpip2JKy98hK/qy/BMOyB+uMsuxvfVHk1vLx 402ilSiWGQG3DTvee8CMgum1ZwSnyf+XzGu0mKMLQIxjMPF8iZ7u/dR5r1XOhVh4cNcs Zpkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=7Lbqc+lyoWjCqrimnvHPiamTYbjWdVi10x1HR0hZ3WU=; b=ErzCu+QYy00925M225vvKuRRUK8XqAIkwCwoP8oFrTabXBtf/KUZOg0r6dCglVA43x diXnYxsyPVfB8FgGZLhpu837+j/oOfqQzw7+8FaDimjXZWHWZ8GmwJpNhQn7ogWh5TFc Jz/k6tBrC8JpImPmFTHXFrWOdDzOIF40keWAxZZT47xCzlsCWozkL214L16hR8b269Gd 5j6H7/KSwnD2z4TZpy9fGUB2XuUmDLM20pe8ps4A5T/rK0qwxwqYl3jE69tgvff/4pUX 7ineMjSBTeFhObT1vYgnv1+DNBrDfKP3CMU8YOJg4ykNKQm2b57rI6ZMt/v4b13tjd+J 2xuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g10si16815388iow.86.2021.05.24.22.25.54; Mon, 24 May 2021 22:26:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230454AbhEYFQx (ORCPT + 99 others); Tue, 25 May 2021 01:16:53 -0400 Received: from muru.com ([72.249.23.125]:59920 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230218AbhEYFQt (ORCPT ); Tue, 25 May 2021 01:16:49 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 64F1D807E; Tue, 25 May 2021 05:15:24 +0000 (UTC) Date: Tue, 25 May 2021 08:15:12 +0300 From: Tony Lindgren To: Vladimir Zapolskiy Cc: Dario Binacchi , linux-kernel@vger.kernel.org, Drew Fustini , Linus Walleij , Andy Shevchenko , linux-gpio@vger.kernel.org Subject: Re: [PATCH v3 2/3] pinctrl: core: configure pinmux from pins debug file Message-ID: References: <20210520202730.4444-1-dariobin@libero.it> <20210520202730.4444-3-dariobin@libero.it> <87ea9971-9e15-c595-95cc-14c68b0b68d8@mleia.com> <1972814783.387983.1621877304255@mail1.libero.it> <414c9176-7922-929f-e82e-f80f07e91b2c@mleia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <414c9176-7922-929f-e82e-f80f07e91b2c@mleia.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Vladimir Zapolskiy [210524 18:52]: > Thus a higher level of abstraction is wanted: > > * writing data to I/O mem -- not good enough, > * writing data to pinmux/pinconf I/O mem -- better, but not good enough, > * writing *valid* data to pinmux/pinconf I/O mem -- that's right. > > The validity of data is defined by a developer, the abstraction name > has been mentioned multiple times, it's pin groups and pin group functions. Sounds like the planned interface should only allow changing between already defined pingroups, and only if the pins are unclaimed. That would leave out the issues tinkering with raw register data. And it probably should also allow adding and removing new pingroups out of the already defined pin functions that are unclaimed. I also think such interface should be sysfs and not debugfs eventually. Regards, Tony