Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4076468pxj; Mon, 24 May 2021 23:19:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPgsjpfBTDZSEsz2GTBwZ4HG2RaF8o6tgpMNsA4b8Ie+yEM6hqJdWYpEOb4gZ5VUrQ4OWz X-Received: by 2002:aa7:c441:: with SMTP id n1mr29881253edr.6.1621923541466; Mon, 24 May 2021 23:19:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621923541; cv=none; d=google.com; s=arc-20160816; b=XPWGC+cj/BShdpvxxVbgiLTHzTLM4rtSNZkrIYfnEdc+s76BrcU//tiGYOP3Bo6uUi 3QLyejI/rSIp9fMbzsGb6TOVUDl8ptPXkPu6+116wkiuioqDEkPE9OCkPAbA/LwmMrmc Ea4oKE8Hw8wdvg4254124DK+OSGBzEynKFWRTzdN6cA6nmvhHGX7d9tiB58GMqAvTWmm tQgXW1TmGXlxMcnGlhzHZXWB5UVLIBsGU8K7RvAx9rKkHcIQXOWXu/FbDSxRUKCfPnEg To30YHaU/8sdvOFEhcuuphWQdAy0YfULQHSwhr1G1xNS8u9DJ3P+Y56HvfmGRQX+9CCo cGzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=mvGugPQi8+3dOuffN32xHRjYlPesR3n2BLe/RI1P+ME=; b=yXfxtY+RWZzvgYdNFecjA/hRei399hE6akQeTQVxTaUnwbg8OQKjENa3biZHRB0QIa CvC9XrqeExk0eiVAbMRpvFGPUgU66iYy5MVfJJ4+j2VJ/M7J1Zg0rOwj9lUQLHb7R37S Z3FSSoQahGurXkfrrEAwwVVJ+tSfbX61jTqZoKBhQXr5++yaWgcT4XE4MnKgNffn8Li4 TmNBDDwfwo2FaVH5LafJY1y+w2yIXgK11lt1WC1tXmFAxuxWFW5a/918beur5kIXRjv9 l+pkgCFRSo6RqP9McX2F121i9LwKE++STUtnizPdUia5mmGXWoo06JaG2dbGWHXxSzr6 JKxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lx17si10885184ejb.61.2021.05.24.23.18.39; Mon, 24 May 2021 23:19:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231137AbhEYGTH (ORCPT + 99 others); Tue, 25 May 2021 02:19:07 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5695 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230387AbhEYGTG (ORCPT ); Tue, 25 May 2021 02:19:06 -0400 Received: from dggems703-chm.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Fq3hM1jM5z1BQrK; Tue, 25 May 2021 14:14:43 +0800 (CST) Received: from dggema769-chm.china.huawei.com (10.1.198.211) by dggems703-chm.china.huawei.com (10.3.19.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Tue, 25 May 2021 14:17:34 +0800 Received: from [10.174.179.215] (10.174.179.215) by dggema769-chm.china.huawei.com (10.1.198.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 25 May 2021 14:17:33 +0800 Subject: Re: [PATCH -next] xen/pcpu: Use DEVICE_ATTR_RW macro To: Boris Ostrovsky , , CC: , References: <20210523070214.34948-1-yuehaibing@huawei.com> From: YueHaibing Message-ID: Date: Tue, 25 May 2021 14:17:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggema769-chm.china.huawei.com (10.1.198.211) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/24 20:48, Boris Ostrovsky wrote: > > On 5/23/21 3:02 AM, YueHaibing wrote: >> Use DEVICE_ATTR_RW helper instead of plain DEVICE_ATTR, >> which makes the code a bit shorter and easier to read. >> >> Signed-off-by: YueHaibing > > > Do you think you can also make similar change in drivers/xen/xen-balloon.c and drivers/xen/xenbus/xenbus_probe.c? > Sure, will do that in v2. > > > Thanks. > > -boris > > . >