Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4152795pxj; Tue, 25 May 2021 01:23:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJza7AdCIUgpfsKC1BzS4aq4nKu8eyA0uROrUu1MKYCOo/eu4+O98WZ5gSzIBqW0nJN6+fKq X-Received: by 2002:a05:6638:138e:: with SMTP id w14mr28664723jad.33.1621931000051; Tue, 25 May 2021 01:23:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621931000; cv=none; d=google.com; s=arc-20160816; b=mbCeINDXoqQIFLGaEmunNSqH2/Gy96TNjJ/xtbsJNdh/bsdNCpfxWV5TPfM+vfCHCh Ta5AOVLCrM49sCxsOC06MN28/HNB8ENZlDGhc6xYjb1RqtgnuTdGukrwbwNzp0pYp12S G3cl6g192Q+RFqMmbW9SKXs+1Ryrz8BN3HecYnevpD3adFc6A+HPn+vqDlnRmCOrS2zx tmpwlEz7Rn44PSPUObKBkzIMo9yrg8TDe84RUun3NoUpPZvn5oAYYL0HsxP+9um9VgbI NdPXyVLuAERlwdFCCu00Rn3JxlpjDg4lzRrvL6Q/WVtzTjGL/CTCpZeZQ6xQ27KJgPkb HGcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=mFrLKjx227jLbVbX0QuAMdsMDPH43Of7iC/2lHJE1RM=; b=pF0ba/AMzlfsBSnaTRgI7hq+8jLi7fP9VNF9kLrx7vqdQFmDB7jVbp3VyXoQiGZLRM KRaLR5u8mOjqMmAfZRJvOYvaUZGPGqX0ciUahRzZBNWowtUvhP84z+oZeu3YxNUsoiQ8 eGUPSK+YRg5/7RNHGA5Yqd1XgLKx+A+BJqnHGLC/i2CqpaXB3Xf0jgaKLm93kodM9AAv 6W4ZS4+Tq+s9qUbUADcS+cZnUjGtMXpBlWzNaz0pQCFXTLj+2A3XsaMMxPgPf2vEAWyf cbZAhJX8rirlCxdnRCySs54yBPWagR6pn7kY5YtU1lfxRPaF3d4xnrelDYwCZTMtcpNW RJKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=cnuk98TH; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l17si16861185jaj.81.2021.05.25.01.23.07; Tue, 25 May 2021 01:23:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=cnuk98TH; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229786AbhEYHOa (ORCPT + 99 others); Tue, 25 May 2021 03:14:30 -0400 Received: from mx2.suse.de ([195.135.220.15]:38042 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhEYHO3 (ORCPT ); Tue, 25 May 2021 03:14:29 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1621926779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mFrLKjx227jLbVbX0QuAMdsMDPH43Of7iC/2lHJE1RM=; b=cnuk98THGytIPMklHLkASVx3uVxo8jS8XpVUZatQLOfnWtLA11EHI25tgT1pL1Vz+EwX7d 8oBSIihU5MS5pueinvNaypCGc86WOou65GAR4M6o5A0ZaW7Tg+GMd4JpwoLaIOiB+WPybT UVdlw1Nbn2UHePFitgDN0u4phDd8l4E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1621926779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mFrLKjx227jLbVbX0QuAMdsMDPH43Of7iC/2lHJE1RM=; b=e5+zqMx+Xl4i8jMrp5X7spni6sgBQ5571DtYJTJJgsnk/IwUY1Bg91tt62drPHvlzMg3+R 4HsVgM2ytQzeV7BQ== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A7853AEAA; Tue, 25 May 2021 07:12:59 +0000 (UTC) Date: Tue, 25 May 2021 09:12:59 +0200 From: Daniel Wagner To: Christoph Hellwig Cc: Sagi Grimberg , Keith Busch , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Jens Axboe Subject: Re: [PATCH] nvme: Use NN for max_namespaces if MNAN is zero Message-ID: <20210525071259.j5g7koxqad7hwpkp@beryllium.lan> References: <20210521144734.90044-1-dwagner@suse.de> <20210521145306.ld7jc6alchimyzny@beryllium.lan> <20210521152702.GB29013@redsun51.ssa.fujisawa.hgst.com> <20210524073703.GA24372@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210524073703.GA24372@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 24, 2021 at 09:37:03AM +0200, Christoph Hellwig wrote: > I think we should add a sanity check for that and reject the broken > controller if that is not the case rather than working around it. Alright. I understood from the spec, that in the non ANA case the NN field should still be case though?