Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: fJnQoZ6GzfbC2p/nuN+FRwYLl6HsPlDOBjPGgi8iuUx/HQhShoWvkzn4wQKrs9oqpW0Yan6uiz
 G2Llo6hZOX7w==
IronPort-SDR: 03bxMCJnHjkapOYeBavX3PK6rCBaqzbrD754BtcWIUXQm6MdhrnVdDmwdedAwlJQ1BK16JcpW0
 X6QlnuI5o7FQ==
Date:   Tue, 25 May 2021 12:28:17 +0300 (EEST)
From:   Kai Vehmanen <kai.vehmanen@linux.intel.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Richard Fitzgerald <rf@opensource.cirrus.com>
cc:     broonie@kernel.org, cezary.rojewski@intel.com,
        liam.r.girdwood@linux.intel.com, yang.jie@linux.intel.com,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        patches@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: Intel: boards: Select SND_SOC_HDAC_HDMI for
 Soundwire machine driver
In-Reply-To: <9ed54875-fe77-f70f-9085-0f3b4c9d576e@linux.intel.com>
Message-ID: <alpine.DEB.2.22.394.2105251158580.3922722@eliteleevi.tm.intel.com>
References: <20210520163324.19046-1-rf@opensource.cirrus.com> <9ed54875-fe77-f70f-9085-0f3b4c9d576e@linux.intel.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7 02160 Espoo
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

Hi,

On Mon, 24 May 2021, Pierre-Louis Bossart wrote:

> On 5/20/21 11:33 AM, Richard Fitzgerald wrote:
> > Add select of SND_SOC_HDAC_HDMI for SND_SOC_INTEL_SOUNDWIRE_SOF_MACH.
> > Without this the build results in missing references to
> > hdac_hdmi_jack_port_init and hdac_hdmi_jack_init.
> Kai, can you comment on this one? There is nothing specific to HDMI in this
> driver.

usage of hdac-hdmi is removed in newer mach drivers (like 
sof_da7219_max98373, sof-pcm512 and ehl_rt5660 -> and there's no select 
for SND_SOC_HDAC_HDMI for these). For older ones, we've kept hdac-hdmi in 
to keep compatibility.

For sof_sdw, there are still calls to hdac_hdmi_jack_init() and friends
in sof_sdw_hdmi.c, so this is a real problem.

I'd say a better fix is that we remove the hdac-hdmi support from sof_sdw.
I can do a patch for that.

> Something's inconsistent here, it's not limited to SoundWire I am afraid

I checked all the related mach drivers and the Kconfig definitions are 
correct for others. So select is done to HDAC_HDMI whenever the mach 
driver uses hdac_hdmi_jack_*().

Br, Kai