Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 May 2021 17:00:33 +0900
From:   Hyeonggon Yoo <42.hyeyoo@gmail.com>
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Oliver Neukum <oneukum@suse.com>,
        Vasily Khoruzhick <anarsoul@gmail.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: line6: Improve poor error handling in
 line6_init_cap_control
Message-ID: <20210525080033.GA13895@hyeyoo>
References: <20210524173644.GA116662@hyeyoo>
 <s5hh7ire1jq.wl-tiwai@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <s5hh7ire1jq.wl-tiwai@suse.de>
Precedence: bulk

On Tue, May 25, 2021 at 09:05:13AM +0200, Takashi Iwai wrote:
> Those resources are freed in the common destructor of the card
> instance, line6_destruct(),

Oh my god, I missed line6_destruct.

> at disconnect callback, so it's redundant
> to release them here; even worse, since you haven't re-initialize with
> NULL, this change would lead to double-free.

Yes then it can cause double-free..

>
>
> thanks,
>
> Takashi

I made a mistake, I'm so sorry to take your time...

Thanks,
Hyeonggon