Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210517112044.233138-1-aisheng.dong@nxp.com> <20210517112044.233138-6-aisheng.dong@nxp.com>
 <69b5a56c-e9a0-01e7-5fd5-78c6e656fa68@redhat.com>
In-Reply-To: <69b5a56c-e9a0-01e7-5fd5-78c6e656fa68@redhat.com>
From:   Dong Aisheng <dongas86@gmail.com>
Date:   Tue, 25 May 2021 16:39:45 +0800
Message-ID: <CAA+hA=Rp-vGaLKO+diaGr5UqZTMEOM-ED0++NWzih8MgD3z9=A@mail.gmail.com>
Subject: Re: [PATCH 5/5] mm/page_alloc: improve memmap_pages and dma_reserve
 dbg msg
To:     David Hildenbrand <david@redhat.com>
Cc:     Dong Aisheng <aisheng.dong@nxp.com>, linux-mm@kvack.org,
        open list <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 25, 2021 at 4:01 PM David Hildenbrand <david@redhat.com> wrote:
>
> On 17.05.21 13:20, Dong Aisheng wrote:
> > Make debug message more accurately.
> >
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> >   mm/page_alloc.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index 3100fcb08500..16f494352f58 100644
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -7263,14 +7263,15 @@ static void __init free_area_init_core(struct pglist_data *pgdat)
> >                                       pr_debug("  %s zone: %lu pages used for memmap\n",
> >                                                zone_names[j], memmap_pages);
> >                       } else
> > -                             pr_warn("  %s zone: %lu pages exceeds freesize %lu\n",
> > +                             pr_warn("  %s zone: %lu memmap pages exceeds freesize %lu\n",
> >                                       zone_names[j], memmap_pages, freesize);
> >               }
> >
> >               /* Account for reserved pages */
> >               if (j == 0 && freesize > dma_reserve) {
> >                       freesize -= dma_reserve;
> > -                     pr_debug("  %s zone: %lu pages reserved\n", zone_names[0], dma_reserve);
> > +                     pr_debug("  %s zone: %lu pages reserved for dma\n",
> > +                              zone_names[0], dma_reserve);
>
> ... which is not really correct I think. See the comment above
> set_dma_reserve(). It's called dma_reserve because it involves the first
> zone -- where many unfreeable allocations like the kernel image end up.
>
> Memory is not reserved for dma purposes ... and the zone name should be
> sufficient.

You're right. I will drop this line of change.
Thanks

Regards
Aisheng

>
> --
> Thanks,
>
> David / dhildenb
>
>