Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4235193pxj; Tue, 25 May 2021 03:27:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzD3ojHpC3VtqzqsUHvfvCK4Ph1YNEBcpaK35FNkO0MQmRhtgcpjbau66aC5DDXGg+V5vby X-Received: by 2002:a17:906:4a81:: with SMTP id x1mr27279097eju.508.1621938469143; Tue, 25 May 2021 03:27:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621938469; cv=none; d=google.com; s=arc-20160816; b=I3sRIORbJ4wbaQ98EWutfBncjW74xjcB6VLzKXDZJ1IvGmiPEJqXbj+toXCuwE1iRq mMLhgRAs6zobQkDgXMVa9/9/TO73ZH5cdY2Bg6OvQ44ji/Hy1iLkvz+DKaIUWa15FlwF o/mobPNXqf6ie7o4NVSBBmyKMPLzlm8/Iv9VkpO7ZWJEa8JsL0sUAxdAqwnOpN4nx0Dx luA7gKAYEPRgrSC5PhDXc960gt6wk42wFxv+d33AquCEU5E9E+p0ecvD+jjit1J52NoQ V+hK12gEd5Om8WyfPJYrrCUsQhsCJZ1Kp009yg3E4pG1bZrUAwLp5Ezz0tFYTucVVLn3 fFRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=S1MKc2LTzqFfMkbzes6qor4rlMA0FRJOF8EOUe2EQAk=; b=uzr+Vb8hXpBmC0aTb/46vOz6eSyZfWud131GvyJsdCNAw9roD00C7jGcBZhn0zn6cu 5r6++ALzRN3YSQpndLdPi9lgoz8iLC0pEVngTVc1UQ96JKdUknahNfC2vth8VdO8e5nd LiD0ntXQHvZYq5Qe7QYI+DgLtRuMLZzsVaKF9fkUkbB4ToBJPgLTHf3KvB/Mgi+nw5HC AjPrVrUWMG6rI8Qko5/6+coLo183rp7VkqzEyQ69V4pIL3y8bM287l4/cOpXxPFmQT5t j9wrIs+5twHjsrFZ1QmEyRq/aYMntqQLYkHqpyADE5yORO8EhuRXpDCqqvrtxNINOhms 8WDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm2 header.b=Nd7m+vMG; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=jSK+YWcG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y65si17128541ede.79.2021.05.25.03.27.26; Tue, 25 May 2021 03:27:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm2 header.b=Nd7m+vMG; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=jSK+YWcG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231374AbhEYIfc (ORCPT + 99 others); Tue, 25 May 2021 04:35:32 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:47319 "EHLO wout5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbhEYIfT (ORCPT ); Tue, 25 May 2021 04:35:19 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 08861133D; Tue, 25 May 2021 04:33:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 25 May 2021 04:33:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=S1MKc2LTzqFfMkbzes6qor4rlMA 0FRJOF8EOUe2EQAk=; b=Nd7m+vMGwBXoe5QAu5HYu6IxXnVBTbEE+4uv06Uq/hM BeETs5F7qrxEm/LoKyc3nSFfOw3V38Ad1bG97KUJFXrFKoeeIVrHHiFIDqc9HTYc kSk1Fh04MDN6TpX3GkC8H1B9MeQha22lXIuXc1tHIJT6if2hJO4mM1nc7sYnURUJ k1hTCemd7L1z1VHY0znscSdcZY/I3ATUDz+zkzZkoaNR4fCEKr2i+S7naRAPwJg1 cI7pj1GwQNyfTLceZ/Urs3FS0Z0hXnikXj5RIGike9k1qHI3nbdEcOzLZR46DtD7 3nckeiNWoKivRpF1Xs5mLVq4A3jkOlRmeZ0p4zZ+hgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=S1MKc2 LTzqFfMkbzes6qor4rlMA0FRJOF8EOUe2EQAk=; b=jSK+YWcG1vjuJHY2ewMiRj eRV2eoEFALrfZo3MiAnRwUafppEjmAPvY1tTUOSMQguzTAh4cOqQjxi/iGbC/x+f P9su7ZiFCvDzvIveaopKAdUrPMktK6W+6esiTv+u/CnJQ+Sani+t0WG0XFSRS9Zg ttlqqpMku5QRZdJ6GVGsD+TJuMG48XYpr136bkg1lz0bjKxE/NG2GChHPBwm3w8R Np5eYdx7iGj0OnK2BDJwRyLNaWze7S36XZmrMDwrpZTsGpM5C710N3d3yB9ebfjC 41jgiKWNzR2QA8gG3ICtzLzKMufQcb27m/QMH6l8p4TXwu6nDrAnBdzD9amOBtcw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdekuddgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 May 2021 04:33:20 -0400 (EDT) Date: Tue, 25 May 2021 10:33:18 +0200 From: Maxime Ripard To: Zou Wei Cc: emma@anholt.net, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] drm/vc4: hdmi: Fix PM reference leak in vc4_hdmi_encoder_pre_crtc_co() Message-ID: <20210525083318.il7fpw77hqz4xxos@gilmour> References: <1621840854-105978-1-git-send-email-zou_wei@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c42up2dtt3g7m2xe" Content-Disposition: inline In-Reply-To: <1621840854-105978-1-git-send-email-zou_wei@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --c42up2dtt3g7m2xe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 24, 2021 at 03:20:54PM +0800, Zou Wei wrote: > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. >=20 > Reported-by: Hulk Robot > Signed-off-by: Zou Wei Applied, thanks Maxime --c42up2dtt3g7m2xe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYKy2TgAKCRDj7w1vZxhR xaZaAQDZDCc9ASSbGCFKYex0RNg+c1/DnKu1cWu6Oi+cYt5y/gEA5/RuBztawrSQ 5dxqSNOHRwo/PUAIcARGH7Ea4vxBFws= =olsI -----END PGP SIGNATURE----- --c42up2dtt3g7m2xe--