Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4236809pxj; Tue, 25 May 2021 03:30:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIspWsWvossSFHKaZ1G12K4z8HTleCHVX0HP28LOAg2TJT7lmXxIImSMU+Tp26qlbQMOG5 X-Received: by 2002:a05:6402:1345:: with SMTP id y5mr30100971edw.107.1621938630385; Tue, 25 May 2021 03:30:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621938630; cv=none; d=google.com; s=arc-20160816; b=c176N0/AWYx0hZ2nbe6W3ndD0BfYo/m9dusxZvEJ+U8fAzjG1XToQ4+7S6nsGBtjU3 rmOA9vqRNZHxA2g1luXuQ8zgX9eqbMRF3WmOjXEyAWEVkxxszhrN3SKtNYb+PyNIcdzL xz1r2maEs38FEPzqR2Yu37ZhbbUbNQ9XP8KTl02p9i4u2ZC6ho28ZEfetDc351Shggzo zI7ZcUi66f2b+YclibtewO11up2eBnF/hn241XOf2kGLJ2KRbi1yH1sFPmDvYpIdAV/i cw+7qHYB9+yGBG/EnWHsbQqsH3G+LjnOeihGMRWN7KF3Bp69AfOUcgm3aQHZdlev7hND NbMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=YZ3Ozh4XP7BzI8DbgV4JZhRJCwlhR/I/3cWGh2u/7QM=; b=V5aQ/2WJSOpbF3nTuvtx86paN+6MyK7PeAVckxILSz1ONVnaV+QxI4KPBQ7Rw/xwuT aUopD6q/Hz+qlrzM5KaqyItE4LvAMbURPaEj/1fs5KkCCqwoGVeVuTZlHqEZ5KJQD604 DC+ACcWco0ieknuNqunnsDxg//hNXkNjo7hngR39DZOfzov7TKx8ssikWVvacJdt6AjF VxhtStfQ0n/dGJhHSjkMYsvEmRzGdi46kp1fQdqHm0QFOfRIis8gj8qQOiz7EF3szd5M XQ65wUER/16OQKYgkfIT4vcNxQoWsW6CGrde4ibd091JO0uHM7EGTgS0zKWIS6UE6o7k tkQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m10si14521560eds.259.2021.05.25.03.30.07; Tue, 25 May 2021 03:30:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232256AbhEYIyu (ORCPT + 99 others); Tue, 25 May 2021 04:54:50 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:40199 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S232226AbhEYIyt (ORCPT ); Tue, 25 May 2021 04:54:49 -0400 X-UUID: d129fe9da30d4b9c9e983349599130a7-20210525 X-UUID: d129fe9da30d4b9c9e983349599130a7-20210525 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1911523834; Tue, 25 May 2021 16:53:16 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 25 May 2021 16:53:10 +0800 Received: from localhost.localdomain (10.17.3.153) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 25 May 2021 16:53:09 +0800 From: Chunfeng Yun To: Greg Kroah-Hartman , Heikki Krogerus CC: Matthias Brugger , Chunfeng Yun , Thierry Reding , Paul Cercueil , Lee Jones , Guenter Roeck , Hans de Goede , , , , Subject: [PATCH 2/2] usb: common: usb-conn-gpio: use usb_role_string() to print role status Date: Tue, 25 May 2021 16:53:06 +0800 Message-ID: <1621932786-9335-2-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty In-Reply-To: <1621932786-9335-1-git-send-email-chunfeng.yun@mediatek.com> References: <1621932786-9335-1-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-SNTS-SMTP: 775A0B1362276C37A09733E3CEDA3FC8205CFB046EBCE31B5DB8EB0AD349CA1F2000:8 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use usb_role_string() to print role status, make the log readable. Signed-off-by: Chunfeng Yun --- drivers/usb/common/usb-conn-gpio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/common/usb-conn-gpio.c b/drivers/usb/common/usb-conn-gpio.c index 65d89140cd19..7dbe8baed029 100644 --- a/drivers/usb/common/usb-conn-gpio.c +++ b/drivers/usb/common/usb-conn-gpio.c @@ -83,11 +83,11 @@ static void usb_conn_detect_cable(struct work_struct *work) else role = USB_ROLE_NONE; - dev_dbg(info->dev, "role %d/%d, gpios: id %d, vbus %d\n", - info->last_role, role, id, vbus); + dev_dbg(info->dev, "role %s -> %s, gpios: id %d, vbus %d\n", + usb_role_string(info->last_role), usb_role_string(role), id, vbus); if (info->last_role == role) { - dev_warn(info->dev, "repeated role: %d\n", role); + dev_warn(info->dev, "repeated role: %s\n", usb_role_string(role)); return; } -- 2.18.0