Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ASoC: Intel: boards: Select SND_SOC_HDAC_HDMI for
 Soundwire machine driver
To:     Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
CC:     <broonie@kernel.org>, <cezary.rojewski@intel.com>,
        <liam.r.girdwood@linux.intel.com>, <yang.jie@linux.intel.com>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
        <patches@opensource.cirrus.com>
References: <20210520163324.19046-1-rf@opensource.cirrus.com>
 <9ed54875-fe77-f70f-9085-0f3b4c9d576e@linux.intel.com>
 <alpine.DEB.2.22.394.2105251158580.3922722@eliteleevi.tm.intel.com>
From:   Richard Fitzgerald <rf@opensource.cirrus.com>
Message-ID: <d7d3b76a-ad3a-85ac-092b-8bc2bab90430@opensource.cirrus.com>
Date:   Tue, 25 May 2021 10:39:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2105251158580.3922722@eliteleevi.tm.intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 25/05/2021 10:28, Kai Vehmanen wrote:
> Hi,
> 
> On Mon, 24 May 2021, Pierre-Louis Bossart wrote:
> 
>> On 5/20/21 11:33 AM, Richard Fitzgerald wrote:
>>> Add select of SND_SOC_HDAC_HDMI for SND_SOC_INTEL_SOUNDWIRE_SOF_MACH.
>>> Without this the build results in missing references to
>>> hdac_hdmi_jack_port_init and hdac_hdmi_jack_init.
>> Kai, can you comment on this one? There is nothing specific to HDMI in this
>> driver.
> 
> usage of hdac-hdmi is removed in newer mach drivers (like
> sof_da7219_max98373, sof-pcm512 and ehl_rt5660 -> and there's no select
> for SND_SOC_HDAC_HDMI for these). For older ones, we've kept hdac-hdmi in
> to keep compatibility.
> 
> For sof_sdw, there are still calls to hdac_hdmi_jack_init() and friends
> in sof_sdw_hdmi.c, so this is a real problem.
> 
> I'd say a better fix is that we remove the hdac-hdmi support from sof_sdw.
> I can do a patch for that.
> 

Ok with me. I'm not using the hdmi.

>> Something's inconsistent here, it's not limited to SoundWire I am afraid
> 
> I checked all the related mach drivers and the Kconfig definitions are
> correct for others. So select is done to HDAC_HDMI whenever the mach
> driver uses hdac_hdmi_jack_*().
> 
> Br, Kai
>