Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4262435pxj; Tue, 25 May 2021 04:09:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9x/OXZgd9pnXHhHty42IxPrMli7gw/z0m/wQPUktb982ArElFjlIiFsOr32hZGFb+/lS8 X-Received: by 2002:a05:6402:34d2:: with SMTP id w18mr30959276edc.358.1621940950268; Tue, 25 May 2021 04:09:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621940950; cv=none; d=google.com; s=arc-20160816; b=QXWJpmLQGlAm0/5g1B6At0ExSnCz6JCnIf8UbSnVzR1w/cSJdYDqlHN5lT8e+RSTd/ lzhaavCBEywxIqY8tHzUp7QyDskeVzgs8vHA2c+gjfmS0L6SWVp7VDLp0fKLfLLxHM0w uZCuZfbCWtxAmUEZ/JqbwErxa8p5lMuYH1keMoDaIxyXW0CuiPtKVnZNSt3xBVjGR7O1 AdOoJbV/O4P6aFOvOPy4xjv6sNUBF0FGhRIVtWROeQVresjoRN9+QsTBXZm8PqtLOa6C qNV+tBs0PyR9BV/qnvNd0fHjOqI2gop0nnxzFsjqiOTm8hccib/trZ2plmbzod4vhE/V ewJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=0cX4MQpVra2BMcXRlU3xerprz6gkEYcuB3aouAqkZyI=; b=tL8qUzfhgoC+GJQorpmAS8uwLK9PTE0HlUQU6SXIftoO4W836tgTYO1O29bkemu+nE XC6iXxvJd01n7ECYRzILZqZT2lrE+eDZVviu8xU9ONtDXq4H56uC3RikL145aCyNsOlb H685ZDb6h9ObmuhrgHLRspspuTewUNBAXSDMUa0fUmVWm5iyNnln4seSM7ttbNeNg48N xQl/MHABoABm11lAJSgku7nAaNU3l5sCMjbL2X5RI7Km54CAokwg+pOYdrnKoDxk+xX0 JjJtMf/MiUmPG/DdHhTTe+s2JWCcu8rpjwO23PAHabFk0ieHsgumIb8UqvlmIxogl5VM BW6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h14si15542673edr.526.2021.05.25.04.08.39; Tue, 25 May 2021 04:09:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231260AbhEYLBx (ORCPT + 99 others); Tue, 25 May 2021 07:01:53 -0400 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:52522 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbhEYLBt (ORCPT ); Tue, 25 May 2021 07:01:49 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0Ua4Wylo_1621940413; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0Ua4Wylo_1621940413) by smtp.aliyun-inc.com(127.0.0.1); Tue, 25 May 2021 19:00:18 +0800 From: Jiapeng Chong To: aelior@marvell.com Cc: skalluru@marvell.com, GR-everest-linux-l2@marvell.com, davem@davemloft.ne, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] bnx2x: Fix missing error code in bnx2x_iov_init_one() Date: Tue, 25 May 2021 19:00:12 +0800 Message-Id: <1621940412-73333-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eliminate the follow smatch warning: drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c:1227 bnx2x_iov_init_one() warn: missing error code 'err'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index d21f085..27943b0 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c @@ -1223,8 +1223,10 @@ int bnx2x_iov_init_one(struct bnx2x *bp, int int_mode_param, goto failed; /* SR-IOV capability was enabled but there are no VFs*/ - if (iov->total == 0) + if (iov->total == 0) { + err = -EINVAL; goto failed; + } iov->nr_virtfn = min_t(u16, iov->total, num_vfs_param); -- 1.8.3.1