Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210524181707.132844-1-brgerst@gmail.com> <20210524181707.132844-2-brgerst@gmail.com>
In-Reply-To: <20210524181707.132844-2-brgerst@gmail.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Tue, 25 May 2021 20:22:13 +0900
Message-ID: <CAK7LNAS1-4+PrP15ZRpkWB0boX-2b_gYa9gg8_HR5jOmG4HWiw@mail.gmail.com>
Subject: Re: [PATCH 1/3] x86/uml/syscalls: Remove array index from syscall initializers
To:     Brian Gerst <brgerst@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        X86 ML <x86@kernel.org>, Andy Lutomirski <luto@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 25, 2021 at 3:17 AM Brian Gerst <brgerst@gmail.com> wrote:
>
> Commit 44fe4895f47c ("Stop filling syscall arrays with *_sys_ni_syscall")
> removed the index from the initializers for native x86 syscall tables, but
> missed the UML syscall tables.


Ah, right.
I missed cleaning up this in UML. Thanks.

Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>


> Signed-off-by: Brian Gerst <brgerst@gmail.com>
> ---
>  arch/x86/um/sys_call_table_32.c | 2 +-
>  arch/x86/um/sys_call_table_64.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/um/sys_call_table_32.c b/arch/x86/um/sys_call_table_32.c
> index f8323104e353..0575decb5e54 100644
> --- a/arch/x86/um/sys_call_table_32.c
> +++ b/arch/x86/um/sys_call_table_32.c
> @@ -31,7 +31,7 @@
>  #include <asm/syscalls_32.h>
>
>  #undef __SYSCALL
> -#define __SYSCALL(nr, sym) [ nr ] = sym,
> +#define __SYSCALL(nr, sym) sym,
>
>  extern asmlinkage long sys_ni_syscall(unsigned long, unsigned long, unsigned long, unsigned long, unsigned long, unsigned long);
>
> diff --git a/arch/x86/um/sys_call_table_64.c b/arch/x86/um/sys_call_table_64.c
> index 5ed665dc785f..95725b5a41ac 100644
> --- a/arch/x86/um/sys_call_table_64.c
> +++ b/arch/x86/um/sys_call_table_64.c
> @@ -39,7 +39,7 @@
>  #include <asm/syscalls_64.h>
>
>  #undef __SYSCALL
> -#define __SYSCALL(nr, sym) [ nr ] = sym,
> +#define __SYSCALL(nr, sym) sym,
>
>  extern asmlinkage long sys_ni_syscall(unsigned long, unsigned long, unsigned long, unsigned long, unsigned long, unsigned long);
>
> --
> 2.31.1
>


--
Best Regards
Masahiro Yamada