Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Date:   Tue, 25 May 2021 13:36:30 +0200
From:   Thierry Reding <treding@nvidia.com>
To:     Chunfeng Yun <chunfeng.yun@mediatek.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Paul Cercueil <paul@crapouillou.net>,
        Lee Jones <lee.jones@linaro.org>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2 3/3] Revert "usb: common: usb-conn-gpio: Make VBUS
 supply optional"
Message-ID: <YKzhPnMU3PXx+tXK@orome.fritz.box>
References: <1621406386-18838-1-git-send-email-chunfeng.yun@mediatek.com>
 <1621406386-18838-3-git-send-email-chunfeng.yun@mediatek.com>
 <YKezl0nlWFQhLyf/@orome.fritz.box>
 <1621835511.26501.14.camel@mhfsdcap03>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="6moWkyVZP6DJIGB7"
Content-Disposition: inline
In-Reply-To: <1621835511.26501.14.camel@mhfsdcap03>
User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06)
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2021 11:35:05.4481
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: eda579cf-97a0-47e7-7aeb-08d91f7124a4
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT036.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4437
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--6moWkyVZP6DJIGB7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 24, 2021 at 01:51:51PM +0800, Chunfeng Yun wrote:
> On Fri, 2021-05-21 at 15:20 +0200, Thierry Reding wrote:
> > On Wed, May 19, 2021 at 02:39:46PM +0800, Chunfeng Yun wrote:
> > > Vbus is already an optional supply, if the vbus-supply is not
> > > provided in DTS, will use a dummy regulator,
> >=20
> > That statement is not entirely correct. The dummy regulator is
> > substituted only if the supply is in fact not optional. The idea behind
> > that is to allow DTS files that don't specify all required regulators to
> > get away with it, based on the assumption that the supply is one of
> > those always-on supplies that are often not described in DTS.
> Yes, you are right.
> But from the point of result, it indeed can help to handle the absent
> regulator.
> >=20
> > > the warning log is as below:
> > > "supply vbus not found, using dummy regulator"
> >=20
> > And the reason why we get that warning is to point out that the DTS has
> > a bug and that it should be fixed (by adding a proper regulator to take
> > the place of the dummy).
> >=20
> > > This reverts commit 4ddf1ac79e5f082451cd549283d2eb7559ab6ca9.
> >=20
> > But if you read the description of that commit, the purpose of that
> > patch was in fact to make the supply completely optional in the case
> > where we already have the VBUS supply specified for the USB port that
> > the connector is parented to.
> Could you please give an example you mentioned?

You can find examples of this in these:

	arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
	arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts
	arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts

> It seems prefer to provide vbus supply in connector instead of port
> according to dt-binding

My recollection is that the above (or at least some of them) predate USB
connectors.

It's possible that we could convert the above to have the VBUS supply
listed in the connector instead of the port. However, since we have to
preserve backwards compatibility with older device trees, we can't
revert the commit anyway.

Thierry

--6moWkyVZP6DJIGB7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmCs4TsACgkQ3SOs138+
s6EOrA/9E77ghrgkWT2zfVOb/ncuXBSAQeTwDMEllA25DFvOL7IDy+1m9ayU1WNW
2UIY9b2lAmvXnwuCq6e17RpNT6Kstpc7KLtIUzkO7Bhx0XhS0rM2J8Lmb3ibpwT9
JV5nb96d8B67fecVCLoxIMSPaYmLw3aZzYKcrg3F7aJBSbzmkP04zusdpBV80nSK
yfQ8stt3DFI1Q+Hv8W6/v3gtM/lgLve7OUlxpX+IltUqP78k7PPdLi4Tz5vjsbm+
71KmpzyAnDMtSM4GEWG3U6zKaD4YxpdCeYwP9N8oXEfDZBPrEiLohxGuaeqJK023
d56NO62yJuKyD0YDOOyKyxFcZOfK0HBIO2M7YGNU0jR//JSw8RzHF8NwewPGpFTo
Ss3pP4fqLFu0FbFZAzqp1sZPgxBJ8kaJ8XobwO1d+eRSFaS8jlLcRkL4uTI58wEN
d5HtBzVh0s/qfTHRHbQDGYbs2whnHfAJHGwqDso1hNklYD3CnDbIsIMJD9l1emCU
uFcJYBPEgjNRwyBC8rTCNWDl4d2TO2GxIsKhd2j37ONyPIc/DmzgxS+ehFelMgig
l2mvqQk3c7dwUl7Aaxf55sxWGQZ/00KDDnNd4+ov735wFEVoGJFltqcNlfee7vge
bPENAJtpaX8Am+gdpCxhdbFviVGnevJKiEg0n/mKHm7BDkQ/knU=
=VjGV
-----END PGP SIGNATURE-----

--6moWkyVZP6DJIGB7--