Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210517113707.238011-1-aardelean@deviqon.com>
In-Reply-To: <20210517113707.238011-1-aardelean@deviqon.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Tue, 25 May 2021 16:34:52 +0200
Message-ID: <CAMpxmJUafFpcFeVH6ScOMeoRFyY67aJMNk8Yxrnb1XdAucE-gw@mail.gmail.com>
Subject: Re: [PATCH] gpio: gpio-ath79: remove platform_set_drvdata() + cleanup probe
To:     Alexandru Ardelean <aardelean@deviqon.com>
Cc:     linux-gpio <linux-gpio@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Alban Bedel <albeu@free.fr>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, May 17, 2021 at 1:37 PM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
>  drivers/gpio/gpio-ath79.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
> index 678ddd375891..9b780dc5d390 100644
> --- a/drivers/gpio/gpio-ath79.c
> +++ b/drivers/gpio/gpio-ath79.c
> @@ -234,7 +234,6 @@ static int ath79_gpio_probe(struct platform_device *pdev)
>         ctrl = devm_kzalloc(dev, sizeof(*ctrl), GFP_KERNEL);
>         if (!ctrl)
>                 return -ENOMEM;
> -       platform_set_drvdata(pdev, ctrl);
>
>         if (np) {
>                 err = of_property_read_u32(np, "ngpios", &ath79_gpio_count);
> @@ -290,13 +289,7 @@ static int ath79_gpio_probe(struct platform_device *pdev)
>                 girq->handler = handle_simple_irq;
>         }
>
> -       err = devm_gpiochip_add_data(dev, &ctrl->gc, ctrl);
> -       if (err) {
> -               dev_err(dev,
> -                       "cannot add AR71xx GPIO chip, error=%d", err);
> -               return err;
> -       }
> -       return 0;
> +       return devm_gpiochip_add_data(dev, &ctrl->gc, ctrl);
>  }
>
>  static struct platform_driver ath79_gpio_driver = {
> --
> 2.31.1
>

Applied, thanks!

Bart